Application crashes when trying to get string::substr

[alexbnc]

I have this function which is supposed to get me the directory of the application. I am using UNICODE, that's why I use wstring (always somebody must ask things that have nothing to do with my problem)

wstring Location() {
    wstring fulllocation;
    wstring location;
    GetModuleFileName(NULL, (WCHAR*)fulllocation.c_str(), MAX_PATH);
    int last_slash = fulllocation.find_last_of(L"/\\");
    location = fulllocation.substr(0, last_slash);
    return location;
}

The application crashes when it tries to get the sub-string with substr() and I don't understand what is wrong. Thanks for your help!

[alexbnc]

The problem resides in find_last_of((WCHAR*)"/\\"); It returns -1

[guestgulkan]

That is a brain-dead function mate.

GetModuleFileName(NULL, (WCHAR*)fulllocation.c_str(), MAX_PATH); //NO

There will also be no double slashes in the pathname - just single slashes

[alexbnc]

So, what is the correct one to use for this?

[guestgulkan]

This should work

std::wstring Location() 
{
	wchar_t buff[MAX_PATH+10]={0};
    
    GetModuleFileNameW(NULL, buff, MAX_PATH);
    
	std::wstring fulllocation(buff);
  
	int last_slash = fulllocation.find_last_of(L"\\");
 	fulllocation = fulllocation.substr(0, last_slash);

	return fulllocation;
}

[alexbnc]

It did. Thanks!