stars doesn't space properly

who cares (14)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
 

#include "stdafx.h"

#include<iostream>

using namespace std;

void line2(int,int,int);

int main()

{int i;

do
{cout<<"How many rows? ";

cin>>i;


if(i<0)

    cout <<" must be nonnegative\n ";

cout << " ";

}while(i<0);

line2(1,1,i);

system("pause");

return 0;

}

void line2(int m,int n,int p)

{int i;

if(m<n)

     return;

cout << "  "; for(i = 0; i <m; i++)

    cout<<"* ";

if(m>0)

    cout<<endl;


if(m==p||n==0)

   line2(m-1,0,p);

else

    line2(m+1,n,p);
}


My code compiles just fines but stars are suppose to be in the middle but it doesn't space correctly, any ideas why or how to fix it???

1
2
3
4
5
6
7
 
     *
   * *
  * * *
 * * * *
  * * *
   * *
    *

above image is how its suppose to show but it all starts in first line instead of making the correct shape. Thanks
Last edited on
Santosh Reddy (63)
Comment line #24
who cares (14)
line 24 is suppose to space it out. although i does give it one space out it still doesn't show the correct format??
Santosh Reddy (63)
Comment line #24
MiiNiPaa (8886)
Comment line #24
And the winner for most useless answer is here.

who cares, you need to output nessesary number of spaces before your first star.
Fixed (slightly) function:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
 
void line2(int m,int n,int p)
{
    if(m<n)
        return;
    cout << "  ";
    for(int i = 0; i < (p - m); ++i)
        std::cout << ' ';
    for(int i = 0; i <m; i++)
        cout<<"* ";
    if(m>0)
        cout<<endl;
    if(m==p||n==0)
        line2(m-1,0,p);
    else
        line2(m+1,n,p);
}
eklavya sharma 2 (170)
If you didn't know it, in such problems (star printing problems) you should first write general formula and then code using loops (unless you are forced by your professor to use recursion):
n-r " " and r "* "
where n is inputted at the beginning of the program (in your case 4)
and r varies from 1 to n and then n-1 to 1.
Last edited on
who cares (14)
MiiNipaa,

I can't thank you enough!!!


Sharma,

Thanks, but for this assignment i had no choice but to use recursion.
and point taken.
Topic archived. No new replies allowed.