assertion failure

[coder1]

# include <iostream>
using namespace std;
# include <cstring>
# include <string>
# include <xstring>
using namespace std;
int main()
{
string cometname;
long totalc=1;
cin>>cometname;
for (int i=1;i<=7;i++)
{
	if ((int ) cometname[i]>=65)
	if ((int ) cometname[i]<=90)
	totalc*=((int ) cometname[i]-64);

}

string groupname;
long totalg=1;
cin>>groupname;
for (int x=1;x<=6;x++)
{
	if ((int ) groupname[x]>=65)
	if ((int ) groupname[x]<=90)
	totalg=totalg*((int ) groupname[x]-64);

}
if(totalg%47==totalc%47)
	cout<<"GO"<<endl;
else
	cout<<"STAY"<<endl;
}

when i debug this program it says assertion failed,
what is that and how could i fix it? thank you.

[clanmjc]

In the first for loop, what do you think happens when cometname has a size of 4? (or anything less than 7)

Same possible problem below with groupname

[coder1]

oh ok thanks very much, but you didnt tell me what is assertion failure

[LB]

An assertion failure is when the program fails a tst to assert that it is functioning properly.

In your case, accessing an index that is out of bounds fails the test that the index must be in bounds. This check is only in debug mode because it would cause slowdown in release.

[coder1]

ok thank you very much,any ideas how to solve it?

[LB]

Use the .length() function on the strings rather than assuming that 7 and 6 are the correct sizes.

[coder1]

ok, i understand now.thanks,and sorry for disturbance