Files

[skarla]

My source works perfect.The problem is that the (remove(),rename()) functions works but return nonzero number,so they fails all the time.
Why??
THANKS.

#include <iostream>
#include <cstdlib>
#include <cstring>
#include <cstdio>
#include <fstream>


using namespace std;

int main()
{
    char array[100]={"1)open-write,2)open-read,3)rename,4)delete"};
    char name_of_file[100];
    string direction;
    string choice;
    string write;
    string read;
    char new_name[100];
    int menu;
    int player=1;
    ofstream outfile;
    ifstream infile;

while(player==1)
{
player++;

cout<<"Menu:"<<endl;
for(int i=0;i<=50;i++)
cout<<array[i];

cout<<endl;

cout<<"\n\nChoice one of these:";
cin>>menu;

switch(menu)
{

    case 1:
    cout<<"\nYou choice: open-write\n ====================="<<endl;
    break;
    case 2:
    cout<<"\nYou choice the: open-read\n====================="<<endl;
    break;
    case 3:
    cout<<"\nYou choice the: rename\n====================="<<endl;
    break;
    case 4:
    cout<<"\nYou choice the: delete\n====================="<<endl;
    break;
    default :
    cout<<"\nWrong choice.Choose again.\n========================"<<endl;
    player--;

}
}

cout<<"\n\nName of file:";
cin>>name_of_file;

if( strcmp(name_of_file,"myfileprogram.txt")==0 )
{

    cout<<"\nThere is a filename like this."<<endl;
    cout<<"\n\nPlace that file is saved:";
    cin>>direction;


    ////////////////////////////////////////////////////////////
    ////////////////////////////////////////////////////////////
    ////////////////////////////////////////////////////////////
    ////////////////////////////////////////////////////////////
    ////////////////////////////////////////////////////////////

    if(direction=="C:" || direction=="c:")
    {

     ////////////////////////////////////////////////////////////
     ////////////////////////////////////////////////////////////
     //open-write
     if(menu==1)
     {
      outfile.open("C:\\myfileprogram.txt",ios::out | ios::app);
      if(outfile.is_open())
        {
          cout<<"\nFile is opened";

          cout<<"\n\nWrite:";
          cin.ignore();
          getline(cin,write);

          outfile<<write;

        }

       else
        {
           cout<<"\nFile is not opened"<<endl;s;
           exit;
        }

     }

     ////////////////////////////////////////////////////////////
     ////////////////////////////////////////////////////////////
     //open-read
     else if(menu==2)
     {
      infile.open("C:\\myfileprogram.txt",ios::in);
      if(infile.is_open())
        {
          cout<<"\nFile is opened";

          getline(infile,read);
          cout<<"\n\n\nFile:"<<read<<endl;

        }

       else
        {
           cout<<"\nFile is not opened"<<endl;;
           exit;
        }

     }


     ////////////////////////////////////////////////////////////
     ////////////////////////////////////////////////////////////
     //rename
     else if(menu==3)
     {
         cout<<"\n\nGive new name:";
         cin>>new_name;

         int ren=rename(name_of_file,new_name);

         if(ren==0)
          cout<<"\nFile successfully renamed"<<endl;;
         else
          cout<<"\nError renaming file"<<endl;;
     }


     ////////////////////////////////////////////////////////////
     ////////////////////////////////////////////////////////////
     //delete
     else if(menu==4)
     {
        int rem=remove(name_of_file);

        if(rem==0)
         cout<<"\nFile successfully deleted"<<endl;
        else
         cout<<"\nError deleting file"<<endl;;

     }


    }


    ////////////////////////////////////////////////////////////
    ////////////////////////////////////////////////////////////
    ////////////////////////////////////////////////////////////
    ////////////////////////////////////////////////////////////
    ////////////////////////////////////////////////////////////

    else if(direction=="default")
      {

       ////////////////////////////////////////////////////////////
       ////////////////////////////////////////////////////////////
       //open-write
        if(menu==1)
        {
          outfile.open("C:\\myfileprogram.txt",ios::out | ios::app);
          if(outfile.is_open())
           {
             cout<<"\nFile is opened";

             cout<<"\n\nWrite:";
             cin.ignore();
             getline(cin,write);

             outfile<<write;
           }

          else
           {
              cout<<"\nFile is not opened"<<endl;;
              exit;
           }

        }

        ////////////////////////////////////////////////////////////
        ////////////////////////////////////////////////////////////
        //open-read
       else if(menu==2)
        {
          infile.open("C:\\myfileprogram.txt",ios::in);
          if(infile.is_open())
           {
             cout<<"\nFile is opened";

             getline(infile,read);
             cout<<"\n\n\nFile:"<<read<<endl;

           }

          else
           {
              cout<<"\nFile is not opened"<<endl;;
              exit;
           }

        }


        ////////////////////////////////////////////////////////////
        ////////////////////////////////////////////////////////////
        //rename
        else if(menu==3)
        {
         cout<<"\n\nGive new name:";
         cin>>new_name;

         int res=rename(name_of_file,new_name);

         if(res==0)
          cout<<"\nFile successfully renamed"<<endl;;
         else
          cout<<"\nError renaming file"<<endl;;
        }


        ////////////////////////////////////////////////////////////
        ////////////////////////////////////////////////////////////
        //delete
        else if(menu==4)
        {
          int rem=remove(name_of_file);

          if(rem==0)
           cout<<"\nFile successfully deleted"<<endl;;
          else
           cout<<"\nError deleting file"<<endl;;
        }


      }

    ////////////////////////////////////////////////////////////
    ////////////////////////////////////////////////////////////
    ////////////////////////////////////////////////////////////
    ////////////////////////////////////////////////////////////
    ////////////////////////////////////////////////////////////

    else
     {
        cout<<"\nWrong directory";
        exit;
     }


}


else
{
  cout<<"\nThere is no file like this."<<endl;
  exit;
}


return 0;
}

[Smac89]

-To make code not easily breakable, give more leverage (less strict rules) to the user. Instead of accepting specific file names, just ask for a file and check if it exists where the user specified, then just act accordingly. i.e. don't check for the directory where the file is saved, instead just try opening the file at the path the user specified. I saw you were doing this on lines 62 and 170

-The code contains a lot of syntax errors which when fixed should work.
-The problem lies with the syntax errors and not the remove/rename functions
-I removed the errors and sure enough, it worked

Output:

$ ./File
Menu:
1)open-write,2)open-read,3)rename,4)delete


Choice one of these:3

You choice the: rename
=====================


Name of file:myfileprogram.txt

There is a filename like this.


Place that file is saved:default


Give new name:myfile2program.txt

File successfully renamed
-bash:Desktop$ ./File
Menu:
1)open-write,2)open-read,3)rename,4)delete


Choice one of these:4

You choice the: delete
=====================


Name of file:myfileprogram.txt

There is a filename like this.


Place that file is saved:default

File successfully deleted