Good day everyone!

[rozzaaq]

Hi everyone I'm new here, I'm using English but not so good. Hopefully I can share my few experience with all of you.

For the first post, I wanna ask about using file in c++ as an input output process.

Below is several code that I wrote recently:

1.

#include <iostream>
#include <fstream>
using namespace std;

int main(){
    ofstream myfile("oct-24th-test.txt");
    if (!myfile.eof()){
        myfile << "This is a line.\n";
        myfile << "This is another line.\n";
        cout<<"adding data success";
        myfile.close();
    }
    else 
        cout << "Unable to open file";
    myfile.close();
    
    cin.get();
    return 0;
}

2.

#include <iostream>
#include <fstream>

using namespace std;

int main(){
    ofstream myfile;
    myfile.open("oct-24th-test.txt");
    if (!myfile){
        cout << "Unable to open file";
        exit(1);
    }
    else{
        myfile << "This is a line.\n";
        myfile << "This is another line.\n";
        cout<<"adding data success";
    }
    myfile.close();
    
    cin.get();
    return 0;
}

those two generate:

adding data success

it means I managed to open the file (and of course wrote the file on "oct-24th-test.txt") but the reality is, I opened the "oct-24th-test.txt" and didn't see the string that I meant to be written by the program.

I really confused with this problem, I seek for the articles in internet about using file in c++ as an input output process all day and follow the code they're using but still I've got no results in my "oct-24th-test.txt" file.

FYI: I'm using visual c++ 2010 express

Please anybody help me, I really appreciate your attention.

[Kiana]

I think you need the output/write access flag.

myfile.open("oct-24th-test.txt", fstream::out);

[kbw]

Don't check for eof--a stream may fail for other reasons.
You don't need to call close, an fstream is an object that can close itself.
Kiana's commend above is not correct.

Your code should work. Have you tried opening the file in notepad?

The error check can be done like this.

#include <iostream>
#include <fstream>
using namespace std;

int main(){
    ofstream myfile("oct-24th-test.txt");
    if (myfile){
        myfile << "This is a line.\n";
        cout<<"adding data success";
    }
    else 
        cerr << "Unable to open file";
    
    cin.get();
    return 0;
}

[D80DSL3A]

Another possible solution method here. I've been using this code so I'm sure it works.

#include<iostream>
#include <fstream>// for file I/O
using namespace std;

int main()
{
	//** output file **
	ofstream outFile;
	outFile.open("oct-24th-test.txt", ios::out );

	if( outFile.is_open() )
	{
		cout << "outFile was opened." << endl;
		outFile << "This is a line.\n";
                outFile << "This is another line.\n";	
		
		outFile.close();
	}
	else
		cout << "outFile was not opened." << endl;	


	return 0;
}

[kbw]

Specifying ios::out is redundant. The object is already an ofstream.

Don't call is_open or close. It goes against the idea of a stream. You should check if it's in a good state as per my example. An fstream object can close itself, this isn't Java.