thousand comma separator for numbers

You could look at <locale> (see the reference section of this site).

http://www.cplusplus.com/reference/locale/numpunct/thousands_sep/

(Personally, I wouldn't recommend this notation in scientific work, though.)

Last edited on

Is that the same solution in this video?

https://www.youtube.com/watch?v=9SubQGhfgJQ&t=699s

I copy pasted the code but there were still errors: c:\users\neo\downloads\workspace\c++vs6\2d\spacecannonsource\textout.h(65) : error C2664: '__thiscall std::locale::std::locale(const char *,int)' : cannot convert parameter 1 from 'class std::locale' to 'const char *'

Last edited on

Please post the code that you are having trouble with. Enough to run if the compile time errors were fixed.

Does this work?

#include <iostream>
#include <sstream>
#include <iomanip>
#include <string>
#include <locale>
using namespace std;

struct separated : numpunct<char>
{
   char do_thousands_sep() const { return ','; }
   string do_grouping() const { return "\03"; }
};


int main()
{
    locale our_local( cout.getloc(), new separated );

    double d = 1000000;
    int i = d + 0.5;
    
    cout.imbue( our_local );
    cout << fixed << setprecision(2) << d << '\n';
    cout << i << '\n';
    
    stringstream ss;
    ss.imbue( our_local );
    ss << fixed << setprecision(2) << d << " and " << i;
    string S = ss.str(); 
    cout << "As a string: " << S;
}

1,000,000.00
1,000,000
As a string: 1,000,000.00 and 1,000,000

Last edited on

error C2664: '__thiscall std::locale::std::locale(const char *,int)' : cannot convert parameter 1 from 'class std::locale' to 'const char *'

im using vs6

Last edited on

recklessasiandriver wrote:
error C2664: '__thiscall std::locale::std::locale(const char ,int)' : cannot convert parameter 1 from 'class std::locale' to 'const char '

Is that:
- the error when running my code?
- the error when running your code?

Please post your CODE, not the error message.

Last edited on

locale our_local( cout.getloc(), new separated );

c:\users\david\onedrive\workspace\c++vs6\2d\spacecannonsource\textout.cpp(155) : error C2664: '__thiscall std::locale::std::locale(const char *,int)' : cannot convert parameter 1 from 'class std::locale' to 'const char *'

I also shifted the code to a different part of my code and got the above error.

Show the WHOLE of your code, not one line.

We need to be able to compile it.

How old is your compiler? Run my code on this site (Click on "Edit & Run").
VS6 is, err, ancient.

Last edited on

im using vs6

All bets are off. That's just not old, it's practically pre-historic! Install the current version of VS2019 Community edition (free).

What's the link to it? I will try and upgrade my code to it.

TheIdeasMan (6817)

What's the link to it?

Do you have Google? Consider using it sometime.

https://visualstudio.microsoft.com/downloads/

Consider:

#include <iostream>
#include <string>
#include <locale>

struct comma_facet : public std::numpunct<char> {
	explicit comma_facet(unsigned char group) : g(group) {}
	char do_thousands_sep() const override { return ','; }
	std::string do_grouping() const override { return std::string(1, g); }
	unsigned char g {};
};

auto set000s(std::ostream& os, unsigned char group = 3)
{
	return os.imbue(std::locale(os.getloc(), new comma_facet(group)));
}

int main()
{
	const auto num {9876543};

	set000s(std::cout);
	std::cout << num << '\n';

	set000s(std::cout, 4);
	std::cout << num << '\n';
}


9,876,543
987,6543

Last edited on

c:\users\david\onedrive\workspace\c++vs6\2d\spacecannonsource\main.cpp(7) : error C2146: syntax error : missing ';' before identifier 'override'

Adding a semi colon then creates this:

c:\users\david\onedrive\workspace\c++vs6\2d\spacecannonsource\main.cpp(7) : error C2059: syntax error : 'return'

Last edited on

What's the link to it?

Do you have Google? Consider using it sometime.

Government has forbidden it's use in our country.