Error in execution

[gaurav13191]

I have the following code to find first and second largest elements of an array:

using namespace std;
#include<iostream>
#include<conio.h>
#include<cstdio>
#include<string.h>

int* create(int);
int maximum(int *,int);
int second_max(int *,int);
void freememory(int*);

int main(void)
{
    int *p,size;
    cout<<"Enter size of the array:";
    cin>>size;
    p=create(size);
    cout<<"\nMaximum elemnt in the array is:"<<maximum(p,size);
    cout<<"\nSecond maximum element in the array is:"<<second_max(p,size);
    freememory(p);
    cin.get();
    return 0;
    
}

int* create(int s)
{
     int *a;
     a=new int[s];
     cout<<"Enter elements of array:";
     for(int i=0;i<s;i++)
     {
             cin>>*(a+i);
             cout<<"\n";
     }
     return a;
}

int maximum(int *a,int s)
{
    cout<<"\nFinding maximum element in array:";
    int max;
    max=a[0];
    for(int i=0;i<s;i++)
    {
       if(*(a+i)>max)
       max= *(a+i);
    }
    return max;
}

int second_max(int *a,int s)
{
    cout<<"\nFinding second maximum element in array:";
    int max,smax;
    max=a[0];
    for(int i=0;i<s;i++)
    {
       if(*(a+i)>max)
       max= *(a+i);
    }
    smax=a[0];
    for(int i=0;i<s;i++)
    {
      if((*(a+i)>=smax) && (*(a+i)!=max))
      smax=*(a+i);
    }
    return smax;
}

void freememory(int *a)
{
     cout<<"\nFreeing memory now:";
     delete(a);
}

The above code compiles fine but when executing does not produce the desired output.. Please help,,I am using dev c++ as compiler..

[Disch]

What is the desired output?

What output are you getting?

EDIT: Unrelated to your problem, but you're freeing your memory incorrectly. Things allocatd with new[] must be deleted with delete[].

line 74 should look like this: delete[] a;

[gaurav13191]

Thanks for your answer.. I corrected it now.. But I need answer that why is the code not producing the desired output..

[gaurav13191]

Well, when I run the code, everything goes fine and I can create the array..

But the statement : "\nMaximum element in the array is:"<<maximum(p,size);
is not being printed means there is some problem with the maximum function which I am unable to find out.

[gaurav13191]

I got the mistake.. getch() was missing..