Snake game

[Dee5]

Hello guys im currently making a snake game.
If you have any suggestions improvements.

#include <iostream>

#include <conio.h>
using namespace std;

bool gameover;

const int width = 20;

const int height = 17;

int x, y, fruitX, fruitY, score;

int tailX[100], tailY[100]; //snake coordinates

int nTail;

enum eDirecton {STOP = 0, LEFT,RIGHT, UP, DOWN}; // Controls

eDirecton dir;

void Setup() {
gameover = false;

dir = STOP;

x = width / 2;

y = height / 2;

fruitX = rand() % width; //display fruit in a random place

fruitY = rand() % height; score = 0;

}

void Draw() {
system("cls");

for(int i = 0; i < width+2; i++)

cout << "#";

cout << endl ;

for (int i = 0; i < height ; i++) {

for (int j = 0; j < width; j++) {

if (j == 0)

cout << "#"; //walls

if (i == y && j == x)

cout << "*"; // snake tale

else if (i == fruitY && j == fruitX )

cout << "%"; // change it to change the fruit

else {

bool print = false;

for (int k = 0; k< nTail ; k++) {

if (tailX [k] == j && tailY [k] == i) {

cout << "*"; print = true;

}

}

if (!print) cout << " ";

}

if (j == width -1)

cout << "#";

}

cout << endl;

}

for (int i = 0; i< width+2; i++)

cout << "#";

cout << endl;

cout << "Score:" << score << endl ;

}

void Input ()
{
if (_kbhit ()) {

switch (_getch ()) {

case 'a':

dir = LEFT;

break;

case 'd':

dir = RIGHT;

break;

case 'w':

dir = UP;

break;

case 's':

dir = DOWN ;

break;

case 'x':

gameover = true;

break;

}

}

}

void algorithm()
{

int prevX = tailX [0];

int prevY = tailY [0];

int prev2X, prev2Y;

tailX[0] = x;

tailY[0] = y;

for(int i = 1;i < nTail ; i++) {

prev2X = tailX[i];

prev2Y = tailY[i];

tailX[i] = prevX;

tailY[i] = prevY;

prevX = prev2X;

prevY = prev2Y ;

}

switch (dir) {

case LEFT:

x--;

break;

case RIGHT:

x++;

break;

case UP:

y--;

break;

case DOWN:

y++;

break;

default:

break;

}

if (x >= width) x =0;else if (x <0) x = width -1;

if (y >= height) y = 0; else if (y < 0) y = height - 1;

for (int i =0; i< nTail ;i++)

if (tailX[i] == x && tailY[i] == y)
gameover = true;

if (x == fruitX && y == fruitY) {

score +=10;

fruitX = rand() % width;

fruitY = rand() % height;

nTail ++;

}

}

int main()
{

Setup();

while (!gameover) {

Draw ();

Input ();

algorithm ();

}

return 0;

}

[highwayman]

Improvement 1) indent your code properly.
Improvement 2) don’t use system("cls")
Improvement 3) don’t use _getch() or conio.h
Improvement 4) don’t use rand()
Improvement 5) don’t use so many globals


Ways to fix:
1) you probably have an auto indent button in your ide somewhere
2 & 3) use a lib like ncurses.h or termios.h to manipulate the console https://www.google.com/search?q=ncurses.h+tutorial
I’d also suggest instead of erasing the entire screen, only erase parts (it reduces the flicker by, like, 100%)
4) use the <random> library http://cplusplus.com/reference/random/?kw=random
5) 🤷‍♂️

[Ganado]

I mean, that would be good, but honestly if you're just making a little console game like this for fun, using functions like getch isn't the end of the world.

Yes, the first two things I see are a lack of indentation, and inconsistent spacing.

if (x >= width) x =0;else if (x <0) x = width -1;

if (y >= height) y = 0; else if (y < 0) y = height - 1;

Saving a few lines of code does not improve readability. Just separate things statements to be on to their own lines. Especially statements that are separated by semi-colons (a small if statement you could get away with being on one line, but personally I think it's a bad habit).

if (x >= width)
    x = 0;
else if (x < 0)
    x = width - 1;

if (y >= height)
    y = 0;
else if (y < 0)
    y = height - 1;

On the other hand, having a bunch of double-spacing also does not helping readability.

case LEFT:

x--;

break;

case RIGHT:

x++;

break;

case UP:

y--;

- As highwayman said, globals should mostly be avoided; having too many just keeps the state of your game hard to keep track of. Pass the necessary variables of the game needed into, e.g. your draw function.
- Having a function called "algorithm" tells me just about nothing.

"prev2x"
You only use your prev2x and prev2y variables inside your for loop, so they could be defined there as well. In general, try to keep variables in the smallest scope possible. This goes back to minimizing the state you have to keep track of at once.

[Dee5]

Thanks for the suggestions

[Ganado]

By the way, I don't remember what rules the classic Snake game had, but I believe most versions of Snake don't kill you if you try to go 'backwards'.

By this I mean, if the snake is going up (w/ a length of 3+), and you press S (down), your game currently gets a game over. Personally, I think it would beneficial to ignore a key press if it would cause the snake to directly intersect with itself.

Other than that, your game seems to be bug free after playing it a few times.

[whitenite1]

@Ganado

By the way, I don't remember what rules the classic Snake game had, but I believe most versions of Snake don't kill you if you try to go 'backwards'.

Actually, yes, that would end the game. Anytime the snake head comes in contact with the body, the snake dies, thus ending the game. Some games also have the snake die if it contacts the edges (sides) of the screen.

[Ganado]

Ah, guess I'm mistaken.
Well then I guess it's a feature not a bug. ;)

[TheToaster]

This isn't an English 101 essay. You don't need to type your code in 12pt double spaced Times New Roman font.

Just kidding lol. But seriously, fix the indentation