Exception Thrown

[abdallahosama]

Im trying to sort an array without using sort built-in function and i dont know why im getting this error ( using visual studio 2017)

Exception thrown: read access violation.
a was 0x1C70112.

[abdallahosama]

#include <iostream> 
#include <algorithm> 

using namespace std;

int main()
{
	int n,t=0;
	cin >> n;
	int* a = new int[n];

	for (int i = 0; i < n; i++)
		cin >> a[i];

	for (int i = 0; i < n; i++)
		for (int j = i + 1; i < n - 1; j++)
		{
			if (a[i] > a[j])
			{
				t = a[i];
				a[j] = t;
				a[i] = a[j];
			}
		}
	sort(a, a + n);
	for (int i = 0; i < n; i++)
		cout << a[i] << " ";
	delete a;
	return 0;

}

[lastchance]

Have a very close look at the middle item of the for statement on line 16.

The second and third lines of your swapping block (currently lines 21 and 22) are the wrong way round.

Remove sort() if you want to test your own routine.

[abdallahosama]

thanks for your attention and i did all the things u mentioned above and im still getting the error on line 17 on run time

Exception thrown: read access violation.
a was 0x21C0112.

also im getting this 3 warnings before i run it

1- Reading invalid data from 'a': the readable size is 'n*4' bytes, but '8' bytes may be read.
2- Buffer overrun while writing to 'a': the writable size is 'n*4' bytes, but '8' bytes might be written
3-'a' is allocated with array new [], but deleted with scalar delete.

#include <iostream>
using namespace std;

int main()
{
	int n,t=0;
	cin >> n;
	int* a = new int[n];

	for (int i = 0; i < n; i++)
		cin >> a[i];

	for (int i = 0; i < n; i++)
		for (int j = i + 1; i < n; j++)
		{
			if (a[i] > a[j])
			{
				t = a[i];
				a[j] = t;
				a[i] = a[j];
			}
		}

	for (int i = 0; i < n; i++)
		cout << a[i] << " ";
	delete a;
	return 0;

}

[lastchance]

abdallahosama wrote:

i did all the things u mentioned above

You didn't do either of the first two things that I mentioned.


Have a VERY close look at the centre of the for statement in this line. Currently (and wrongly):
for (int j = i + 1; i < n; j++)


I also requested that you reverse the second and third lines of this block; currently (and wrongly):

				t = a[i];
				a[j] = t;
				a[i] = a[j];

In fact @doug4 told you the same thing in your other thread (why did you start a new one?) and you ignored him also.

[doug4]

Thanks @lastchance for saying everything I wanted to say to the @abdallahosama.


@abdallahosama - If you are not going to incorporate suggestions and then wonder why your code still doesn't work, I won't bother responding any more.

[abdallahosama]

ah sorry how stupid i was :D , now it works fine and about the other thread the code wasn't clean after i edited it and since im new to post threads i couldn't either delete it so i just marked it as solved :) also thanks to your response

[abdallahosama]

@doug4 i apologize to you i really do but i couldn't handle the situation as i supposed to do