Stacks

[Student1904]

Hello, I am having trouble getting my original value of an int that I use in a while loop and cant seem to display the rest of the base numbers.

#include<iostream>
using namespace std;

class stack
{
private: 

	int a[8];
	int counter;

public: void clearStack() {counter = 0;}
		bool emptyStack() { if (counter == 0) return true; else return false; }
		bool fullStack() { if (counter == 8) return true; else return false; }
		void pushStack(int x) { a[counter] = x; counter++; }
		int popStack() { counter--; return a[counter]; }
};

int main()

{
	int n;
	stack s;

	s.clearStack();

	cout << "Enter a positive number: "; 
	cin >> n; 

	cout << n <<" at base 2 is: ";

	while (n != 0)
	{
		int r;
		r = n % 2; s.pushStack(r);
		n = n / 2;
	}

	while (!s.emptyStack())
	{
		int x = s.popStack();
		cout << x;
	}

	cout << endl;

	s.clearStack();

	cout << n << " at base 8 is: ";

	while (n != 0)
	{
		int r;
		r = n % 8; s.pushStack(r);
		n = n / 8;
	}

	while (!s.emptyStack())
	{
		int x = s.popStack();
		cout << x;
	}

	cout << endl;

	s.clearStack();

	cout << n << " at base 16 is: ";

	while (n != 0 )
	{
		int r;
		r = n % 16; s.pushStack(r);
		n = n / 16;
	}

	while (!s.emptyStack())
	{
		int x = s.popStack();
		cout << x;
	}
}

/*
Enter a positive number: 163
163 at base 2 is: 10100011
0 at base 8 is:
0 at base 16 is: Press any key to continue . . .
*/

[Repeater]

You are changing the value of n. How is your base 8 section meant to know what the user input was?

[Student1904]

Okay, should I sent n equal to another variable (for example: int n2 = n;) then use n2 for the while loops? What would be more efficient?

[Repeater]

Okay, should I sent n equal to another variable (for example: int n2 = n;) then use n2 for the while loops?

Yes.

What would be more efficient?

Efficient for what? Memory use? It's basically free. Run time? It's basically free.