solve this problem

[lost girl]

this is the Q:

Write a function named FirstOcurence that takes as parameters an array of char(c-strings) and a character c. The function should return a pointer that point to the first occurrence of c in the string. If c is not found the function should return NULL.
The function prototype is: char* FirstOccrence(char arr[], char c)

char* FirstOccrence(char arr[], char c)
{

   char *p;
   
   
   for(int i=0;i<strlen(arr);i++)
   {
   p= & arr[i];
  if (p[i]==c)
  {
 
   return p;
  }
  }
   return NULL;
  }

check it to me

[m4ster r0shi]

You got a little confused here: if (p[i]==c). p is not an array, its a pointer to char. Of course your compiler won't complain about this but this won't work as you expect. Do your checking like: if (*p==c). Or you could just omit the temporary char pointer and do it like this:

char * FirstOccurence(char arr[], char c)
{
    //call strlen once
    int size=strlen(arr);

    for(int i=0;i<size;i++)
    {
        if (arr[i]==c)
            return arr+i;
    }

    return 0;
}

[guestgulkan]

Enough is enough - Any thread like this (along the lines of - here is my problem do it for me, or here is my broken code fix it) should just be deleted - that is my opinion.

[m4ster r0shi]

But (s)he had almost solved his/her problem by himself/herself. I'd say that the only thing (s)he did wrong was the choice of the name of the topic... All I did was correct a minor problem and provide a slightly more optimized solution...

[packetpirate]

This is the "General C++ Programming" forum, not the "Post your homework here so we can do it for you." forum.

[lost girl]

I'm sorry if this is illegal

I just need some help

:)

thanx alot

[packetpirate]

It's not "illegal" by any means, but the fact that you're asking someone to solve your problems for you is pathetic. You're never going to learn anything if you keep having others do your homework for you.

[lost girl]

but I already put my solution

it is just a title


and it is not "pathetic" if I ask for help ..Iam still learning
this is my opinion
:)
any way thanks I will not ask again
have a nice day

[m4ster r0shi]

Have a nice day yourself, lost girl! I hope we (somehow) helped you find your way... :)

[Albatross]

Okay. To put all of this in far nicer terms, most of us regulars on this forum will never solve your problems for you. Don't even ask, as guestgulkan will probably shout at you again (not without reason; it gets tiring seeing so many posts of this type). You may ask what's wrong with your code, but never ask anyone to do anything for you. Not here.

Have a nice day, and welcome.

-Albatross