Change the variable inside a loop

[adam8797]

Hello,

I'm making a utility for my school to generate a script for out teleprompter. I need to change a variable inside a loop (I will highlight the variable). Heres the code:

#include <iostream>
using namespace std;
int cday;
int Loop;
int TimesLooped;
char test;
char responce;
string Lunch = " ";
string Anchor1 = " ";
string Anchor2 = " ";
string Date = " ";
string anc1 = " ";
string anc2 = " ";
string anc3 = " ";
string anc4 = " ";
string anc5 = " ";
string anc6 = " ";
string anc7 = " ";
string anc8 = " ";
string anc9 = " ";
string anc10 = " ";
int main ()
{
	cout << "What is today's full date?" << endl;
	getline(cin, Date);
	cout << endl;
	cout << "Cycle day..." << endl;
	cin >> cday;
	cout << endl;
	getline(cin, Anchor1);
	cout << "First Anchor's Name?" << endl;
	getline(cin, Anchor1);
	cout << endl;
	cout << "Second Anchor's Name?" << endl;
	getline(cin, Anchor2);
	cout << endl;
	cout << "Today's lunch is..." << endl;
	getline(cin, Lunch);
	cout << endl;
anc:
	cout << "Are there any extra announcements? y/n" << endl << "-";
	cin >> responce;
	getline(cin, anc10)
	switch (responce) {
		case 'y':
			cout << "How many?" << endl;
			cin >> Loop;
			cout << endl;
			while (Loop != TimesLooped) {
				cout << "Type an announcement";
				getline(cin, anc1);
			}
			break;
		case 'n':
			cout << "Good morning DMS.  " << endl << "I'm " << Anchor1 << ", " << endl << "and I'm " << Anchor2 << "." << endl;
			cout << "Todays Date is " << Date;
			break;

		default:
			cout << "invalid responce";
			goto anc;
			break;
	}
	
}

Still working on it. If I left something out tell me. the variable is bolded and underlined in line 51. I need to change it from anc1 to anc2 - anc10 after each loop. The int Loop is the number of times it should loop. int TimesLooped is the amount of times the loop has repeated.

Thanks,
Adam

[TheBear]

Hi Adam,

you could use an array for each of the ten strings. This would look something like this:

// At the top, instead of anc1,...,anc10:
string anc[10];

// ...

// The loop:
int index = 0;
while (Loop != TimesLooped) {
    cout << "Type an announcement";
    getline(cin, anc[index]);
    index++;
}

This works of course for maximal 10 strings. You can also achieve having an (almost) arbitrary number of strings by dynamically allocating the array anc.

Greetings, TheBear

[adam8797]

Hi TheBear,

I keep getting errors with the index++. Im am using xcode for mac. I have placed the errors in the lines of code where they occur.

#include <iostream>
using namespace std;
int cday;
int Loop;
int TimesLooped;
int index = 0; //'int index' redeclared as different kind of symbol
char test;
char responce;
string Lunch = " ";
string Anchor1 = " ";
string Anchor2 = " ";
string Date = " ";
string anc[10];
int main ()
{
	cout << "What is today's full date?" << endl;
	getline(cin, Date);
	cout << endl;
	cout << "Cycle day..." << endl;
	cin >> cday;
	cout << endl;
	getline(cin, Anchor1);
	cout << "First Anchor's Name?" << endl;
	getline(cin, Anchor1);
	cout << endl;
	cout << "Second Anchor's Name?" << endl;
	getline(cin, Anchor2);
	cout << endl;
	cout << "Today's lunch is..." << endl;
	getline(cin, Lunch);
	cout << endl;
anc:
	cout << "Are there any extra announcements? y/n" << endl << "-";
	cin >> responce;
	switch (responce) {
		case 'y':
			cout << "How many?" << endl;
			cin >> Loop;
			cout << endl;
			while (Loop != TimesLooped) {
				cout << "Type an announcement";
				getline(cin, anc[index]);  //invalid types 'std::string [10][char* ()(const char*, int)]' for array subscript
				index++;  //ISO C++ forbids incrementing a pointer of type 'char* (*)(const char*, int)' (2)
			}
			break;
		case 'n':
			cout << "Good morning DMS.  " << endl << "I'm " << Anchor1 << ", " << endl << "and I'm " << Anchor2 << "." << endl;
			cout << "Todays Date is " << Date;
			break;

		default:
			cout << "invalid responce";
			goto anc;
			break;
	}
}

Thanks,
Adam

[TheBear]

I can't reproduce this error here, the program compiles and runs. I assume that there is a variable index already declared in iostream, so maybe changing the name of index to something else does the trick.

[adam8797]

ok I changed index to index2 and it cleared up all of the issues except

while (Loop != TimesLooped) {
				cout << "Type an announcement";
				getline(cin, anc[index2]);
				index++;  //ISO C++ forbids incrementing a pointer of type 'char* (*)(const char*, int)' (2) 

im going to compile it in dev c++ not xcode and try it

thanks,
adam

[Galik]

You need to change the name 'index' every time you use it:

while (Loop != TimesLooped) {
				cout << "Type an announcement";
				getline(cin, anc[index2]);
				index2++;  // <== change it here too