sequence for arduino

[mzulf]

int Relay1=2; // actuator 1 on
int Relay2=1; // actuator 1 off
int Relay3=3; // actuator 2 on 
int Relay4=4; // actuator 2 off
int Relay5=5; // actuator 3 on
int Relay6=6;  // actuator 3 off
int Relay7=7; // actuator 4 on 
int Relay8=8; // actuator 4 off
int Sensorpin1=11; // inductive sensor 1
int Sensorpin2=12; // inductive sensor 2
int Sensorpin3=13; // thru beam sensor
int PIRpin=10; // PIR sensor
int val=LOW;

void setup() {
  // put your setup code here, to run once:
  pinMode (Relay1, OUTPUT); // 
  pinMode (Relay2, OUTPUT); // 
  pinMode (Relay3, OUTPUT); // 
  pinMode (Relay4, OUTPUT); // 
  pinMode (Relay5, OUTPUT); // 
  pinMode (Relay6, OUTPUT); // 
  pinMode (Relay7, OUTPUT); // 
  pinMode (Relay8, OUTPUT); // 
  pinMode (Sensorpin1,INPUT); // Inductive sensor 1
  pinMode (Sensorpin2,INPUT); // Inductive sensor 2
  pinMode (Sensorpin3,INPUT); // Thru beam sensor
  pinMode (PIRpin, INPUT); // PIR Sensor
}

void loop() {
// put your main code here, to run repeatedly:
Reset();
  do {
    if (LOW == digitalRead(PIRpin))
    {
      delay (2000); 
    
        if (LOW == digitalRead(Sensorpin1) && val == digitalRead(Sensorpin2))
        {
          MetalForward(); // Relay1,2 & Relay 7,8
          delay (7000);
          MetalReverse(); // Relay 1,2 & Relay 7,8
          delay (7000);
        }    
       else if (LOW == digitalRead(Sensorpin3))
       {
         PaperForward(); // Relay 1,2 & Relay 5,6
         delay (7000);
         PaperReverse(); // Relay 1,2 & Relay 5,6
         delay (7000);
        }
       else 
       {
         BottleForward(); //Relay 3,4
         delay(2000);
         BottleReverse(); // Relay 3,4
         delay (2000);
       }
    }
} while (1);


}
void MetalForward () 
  {
    digitalWrite (Relay1, HIGH);
    digitalWrite (Relay2, LOW);
    digitalWrite (Relay7, HIGH);
    digitalWrite (Relay8, LOW);
  }

void MetalReverse ()
  {
    digitalWrite (Relay1, LOW);
    digitalWrite (Relay2, HIGH);
    digitalWrite (Relay7, LOW);
    digitalWrite (Relay8, HIGH);
  }

void PaperForward ()
  {
    digitalWrite (Relay1, HIGH);
    digitalWrite (Relay2, LOW);
    digitalWrite (Relay5, LOW);
    digitalWrite (Relay6, HIGH);
  }

void PaperReverse ()
  {
    digitalWrite (Relay1, LOW);
    digitalWrite (Relay2, HIGH);
    digitalWrite (Relay5, HIGH);
    digitalWrite (Relay6, LOW);
  }

void BottleForward ()
  {
    digitalWrite (Relay3, LOW);
    digitalWrite (Relay4, HIGH);   
  }

void BottleReverse ()

  {
    digitalWrite (Relay3, HIGH);
    digitalWrite (Relay4, LOW);
  }

void Reset ()
  { 
   digitalWrite (Relay1, HIGH);
   digitalWrite (Relay2, LOW);
   digitalWrite (Relay3, HIGH);
   digitalWrite (Relay4, LOW);
   digitalWrite (Relay6, HIGH);
   digitalWrite (Relay5, LOW);
   digitalWrite (Relay7, LOW);
   digitalWrite (Relay8, HIGH);
  }

 

whats wrong with this code ? its stuck in paperforward()

[kulkarnisr]

#61 } while (1);

[codewalker]

Cant tell from the posted code.
If the function "loop" is getting called from "digitalWrite", since "PaperForward" is calling "digitalWrite" only, then what

kulkarnisr

said is correct

[mzulf]

#61 } while (1);

its for returning back to value

am i correct ?

[MikeyBoy]

No. The "while" line specifies the condition for continuing to loop. The loop will continue to iterate as long as the condition in that statement is true.

Since 1 is always true, the loop will continue for ever.

[mzulf]

so i have to delete it ?

[MikeyBoy]

Well, obviously you need some sort of condition for your loop.

The first thing you need to decide is under what circumstances you want your loop to exit. Once you've worked that out, you'll be able to make a decision as to whether:

- you want to leave it as 1, and introduce some break statement within the loop when you want it to exit

- you want to change it to a suitable condition

- some combination of both.

[Chervil]

The comment in the code states:

// put your main code here, to run repeatedly: 

It looks as though remaining in that loop forever is an inherent part of the design. If it doesn't do what you want it to do, it is the design which you need to consider first. After you decide what you want the program to do, then you can start to write or change the code for it.

Or possibly the program is working properly, but the data it is getting as input is not as required.