Blackjack Program

[ohsnap1319]

Hi everyone!

I am having a lot of problems with my blackjack program that I just created. Unfortunately I cannot get it to run..if someone could help me with this problem that would be great! Thanks!

#include <iostream>
#include <ctime>

using namespace std;

const int NUMCARDS = 52;
const int NUMATTEMPTS = 5;
const int MAXNUMCARDS = 12;

void displayMenu();
void NewHandMenu();
void ShuffleUpDemCards(bool DeckOfCards[]);
int NewCards(bool DeckOfCards[]);
void cardCharacters(int NewCard);
void PlayersCardHand(int PlayersHand[], int PlayersDealtHand);
void HousesCardHand(int HousesHand[], int HousesDealtHand);
int PlayersHandScore(int PlayersHand[], const int PlayersDealtHand);
int HousesHandScore(int HousesHand[], const int HousesDealtHand);
void ScoresAndHands(int HousesHand[], const int HousesDealtHand, int PlayersHand[], const int PlayersDealtHand);


int main()
{
	time_t qTime;
	time(&qTime);
	srand(qTime);


	bool DeckOfCards[NUMCARDS];
	int PlayersHand[MAXNUMCARDS];
	int HousesHand[MAXNUMCARDS];
	int PlayersDealtHand = 0;
	int HousesDealtHand = 0;
	int badAttempts=0;
	
	
	
	while (false) {
		displayMenu();
		ShuffleUpDemCards(DeckOfCards);
		
		PlayersHand[0] = NewCards(DeckOfCards);
		PlayersHand[1] = NewCards(DeckOfCards);
		HousesHand[0] = NewCards(DeckOfCards);
		HousesHand[1] = NewCards(DeckOfCards);

		HousesDealtHand = 2;
		PlayersDealtHand = 2;
	}

	NewHandMenu();

	char choice;
	bool HitsforPlayer = true;
	int PlayerScore = PlayersHandScore(PlayersHand, PlayersDealtHand);
	int HouseScore = HousesHandScore(HousesHand, HousesDealtHand);
	do {
		cout << "The House's Hand" << endl;
		cardCharacters(HousesHand[1]);
		cout << endl;
		cout << "The Player's Score = " << PlayersHandScore(PlayersHand, PlayersDealtHand) << endl;
		PlayersCardHand(PlayersHand, PlayersDealtHand);

		cout << "Player, would you like to hit(press h) or stay(press s)";
		cin >> choice;

		if(choice == 'h') {
			cout << "Player selects to hit!!\n";
			PlayersHand[PlayersDealtHand] = NewCards(DeckOfCards);
			PlayersDealtHand++;
		}
		else if(choice == 's') {
			cout << "Player selects to stay!!\n";
		bool HitsforPlayer = false;
		}
		else {
			cout << "You entered an invalid choice!!!\n";
			cout << "Please try again! This time press an ""h"" to hit or press a ""s"" to stay!!\n";
			cin >> choice;
		}

		cout << endl << endl;
		PlayerScore = PlayersHandScore(PlayersHand, PlayersDealtHand);
	} while (HitsforPlayer && PlayerScore < 22);

	if(PlayerScore > 21) {
		cout << "I am sorry, but you have busted!!\n";
		cout << "The House Wins the Hand!!!\n";
		ScoresAndHands(HousesHand, HousesDealtHand, PlayersHand, PlayersDealtHand);
	}

	else {
		while (HouseScore < 17) {
			HousesHand[HousesDealtHand] = NewCards(DeckOfCards);
			HousesDealtHand++;
			HouseScore = HousesHandScore(HousesHand, HousesDealtHand);
		}

		bool HouseBusts = (HouseScore > 21);

		if(HouseBusts) {
			cout << "Congratulations, the House Busted!!!\n";
			cout << "You win the Hand!!\n";
			ScoresAndHands(HousesHand, HousesDealtHand, PlayersHand, PlayersDealtHand);
		}
		else {
			if (PlayerScore == HouseScore) {
				cout << "Both your hand and the Houses hand are the same!!\n";
				cout << "The hand results in a push, and no one wins!!\n";
				ScoresAndHands(HousesHand, HousesDealtHand, PlayersHand, PlayersDealtHand);
			}
			else if (PlayerScore > HouseScore) {
				cout << "Your hand is higher than the Houses hand!!\n";
				cout << "You win the hand!!\n";
				ScoresAndHands(HousesHand, HousesDealtHand, PlayersHand, PlayersDealtHand);
			}

			else  {
				cout << "The Houses hand is higher than your hand!!\n";
				cout << "The House wins the hand!!\n";
				ScoresAndHands(HousesHand, HousesDealtHand, PlayersHand, PlayersDealtHand);
			}
		}
	}
}


void displayMenu()
{
	cout << "*******************************************\n";
	cout << "HI, AND WELCOME TO OUR BLACKJACK PROGRAM!!!\n";
	cout << "*******************************************\n";
	
}

void NewHandMenu()
{
	cout << "*******************************************\n";
	cout << "------Starting a New Hand------------------\n";
	cout << "*******************************************\n";

}


void ShuffleUpDemCards(bool DeckOfCards[])
{
	int index;
	for(index=0; index<NUMCARDS; index ++) {
		DeckOfCards[52] = false;
	}
}

int NewCards(bool DeckOfCards[])
{
	DeckOfCards[NUMCARDS] = true;
	int NewCard = -1;
	do {
		NewCard = (rand() % 52);
		if (!DeckOfCards[NewCard]) {
			DeckOfCards = false;
		}
	} while (DeckOfCards);
	return NewCard;
}

void cardCharacters(int NewCard)
{
	const int RANK = (NewCard%13);
	const int SUIT = (NewCard/13);
	if(RANK==0)
		cout << "Ace of";
	else if(RANK<9)
		cout << (RANK+1) << " of ";
	else if(RANK==10)
		cout << "Jack of ";
	else if(RANK==11)
		cout << "Queen of ";
	else 
		cout << "King of ";
	
	if(SUIT==0)
		cout << "Hearts";
	else if(SUIT==1)
		cout << "Spades";
	else if(SUIT==2)
		cout << "Diamonds";
	else 
		cout << "Clubs";
}

void PlayersCardHand(int PlayersHand[], int PlayersDealtHand)
{
	int CardIndex;

	for(CardIndex = 0; CardIndex < PlayersDealtHand; CardIndex++) {
		const int NewCard = PlayersHand[CardIndex];
		cardCharacters(NewCard);
		cout << " ";
	}
	cout << endl;

}

void HousesCardHand(int HousesHand[], int HousesDealtHand)
{
	int CardIndex;

	for(CardIndex = 0; CardIndex < HousesDealtHand; CardIndex++) {
		const int NewCard = HousesHand[CardIndex];
		cardCharacters(NewCard);
		cout << " ";
	}
	cout << endl;
}

int PlayersHandScore(int PlayersHand[], const int PlayersDealtHand) 
{
	int AceCount	= 0;
	int Score		= 0;
	int CardIndex;
	for (CardIndex = 0; CardIndex < PlayersDealtHand; CardIndex++) {
		const int NextCard = PlayersHand[CardIndex];
		const int Rank = (NextCard % 13);
		if (Rank == 0) {
			AceCount++;
			Score++;
		} 
		else if (Rank < 9) {
			Score += (Rank + 1);
		} 
		else {
			Score += 10;
		}
	}
	while (AceCount > 0 && Score < 12) {
		AceCount--;
		Score +=  10;
	}
	return Score;
}

int HousesHandScore(int HousesHand[], const int HousesDealtHand)
{
	int AceCount	= 0;
	int Score		= 0;
	int CardIndex;
	for (CardIndex = 0; CardIndex < HousesDealtHand; CardIndex++) {
		const int NextCard = HousesHand[CardIndex];
		const int Rank = (NextCard % 13);
		if (Rank == 0) {
			AceCount++;
			Score++;
		} 
		else if (Rank < 9) {
			Score += (Rank + 1);
		} 
		else {
			Score += 10;
		}
	}
	while (AceCount > 0 && Score < 12) {
		AceCount--;
		Score +=  10;
	}
	return Score;
}

void ScoresAndHands(int HousesHand[], const int HousesDealtHand, int PlayersHand[], const int PlayersDealtHand) 
{
	cout << "House's Hand: Score = " << HousesHandScore(HousesHand, HousesDealtHand) << endl;
	HousesCardHand(HousesHand, HousesDealtHand);
	cout << "Player's Hand: Score = " << PlayersHandScore(PlayersHand, PlayersDealtHand) << endl;
	PlayersCardHand(PlayersHand, PlayersDealtHand);
	cout << endl;
}

[kbw]

It compiles and runs.

What does this do?

	while (false) {
		displayMenu();
		ShuffleUpDemCards(DeckOfCards);
		
		PlayersHand[0] = NewCards(DeckOfCards);
		PlayersHand[1] = NewCards(DeckOfCards);
		HousesHand[0] = NewCards(DeckOfCards);
		HousesHand[1] = NewCards(DeckOfCards);

		HousesDealtHand = 2;
		PlayersDealtHand = 2;
	}

[ohsnap1319]

The code you are talking about is supposed to get 2 cards for the starting hands of both the player and the house. Also the while loop is supposed to be set to (true) and not (false). Because it is set to false the program does not output right, and therefore doesn't run right. Is there a simpler way at all to write just a simple blackjack program?

[kbw]

Ther idea of using a loop to do turns is ok. I was really pointing you to the while (false) clause.

Have you tried stepping thru your program with a debugger? There is a school of thought (Steve Maguire) that says you should see every line of your code execute.

[ohsnap1319]

I could try that, but I am an absolute beginner at programming. Is there any possible way that you could help me with this program?

[Zhuge]

You should try the debugging approach first and then come to us with specific questions you have about what isn't working.

[kbw]

If you don't have a debugger, you could insert temporary cout statements to show where the program is and the value of relevant variables.

Debugging is a part of programming and you'll learn so much by doing so, however you do it.

[ohsnap1319]

I have changed this program around. Please refer to my new Blackjack Program thread..I am having some problems with that code as well.



http://cplusplus.com/forum/general/17034/

thanks for any help that you can provide me!