error in vector member class

[dkaip]

I am trying to make a class for all files and dirs of folder. Trying

class DIRSandFILES
{
public:
        vector<char*>Dirs;
        vector<char*>Files;
        vector<char*>ChooseFiles;
        DIRSandFILES(char *dir);
        virtual ~DIRSandFILES();
protected:
private:
        bool CheckPath(const char* userPath);
        void dirsAndFilesToStack(char * dir);
        void chooseFiles(char* ext);
        void PuchDirsAndFiles(char * directory);
};

I have problem in
vector<char*>Dirs;

The program works fine before all stuff insert in DIRSandFILES class. Any ideas?

[helios]

I'm gonna go out on a limb and say that you're not actually copying the arrays, you're only assigning pointers to string literals.

[jsmith]

I would strongly suggest using std::string instead of char*.

It will drastically simplify things for you.

[dkaip]

How i can do that? An example to a new to c and cpp?

[jsmith]

std::vector<std::string> dirs;

dirs.push_back( "/usr" );  // This works; std::string is constructible from a const char*
dirs.push_back( std::string( "/usr" ) );  // Same thing, but construction is explicit

// Now comparing strings is easier than char*:
if( dirs.front() == "/root" )
    std::cout << "Root directory\n";

// compared to:
if( strcmp( dirs.front(), "/root" ) == 0 )
    std::cout << "Root directory\n";

[helios]

No .c_str() on line 11?

[kempofighter]

I agree with helios but the other point is still valid. Comparing string to const char* is much easier and intuitive with operator==. Of course this is all conjecture without being able to see an example that demonstrates the original problem. There could be many other problems, although I agree with the suggestions. std::string will make life easier and the program will be more intuitive, safer, and easier to maintain. It'll also allow you to focus on the requirements of the program instead of on reinventing the wheel.

[jsmith]

Line 11 is the vector<char*> case, so no, no .c_str().