printing grade

[42ApX9L8]

This program works EXCEPT for the fact that I can't get it to dipslay the grades in accordance with the scores.

This is the section I think I need to work with:

void printGrade(int oneScore, float average)  //can't figure out how to get this to work right.
{
	oneScore = 0;
	average = 0;
	int count[MAX_SIZE];
	int id[MAX_SIZE];
	int scores[MAX_SIZE];
	string grade;

	computeAverage(scores,count);

	for(oneScore = 0; oneScore < MAX_SIZE; oneScore++)
	{
		if(scores[oneScore] > average + 10)
		{
			grade = "outstanding";
		}
		else if(scores[oneScore] < average - 10)
		{
			grade = "unsatisfactory";
		}
		else
		{
			grade = "satisfactory";
		}
//		cout << left << setw(9) << id[oneScore] << setw(9) << scores[oneScore] << setw(9) << grade << endl;
	}
	
}

Though I'm not completely sure.

Here is the complete code.

#include <iostream>
#include <fstream>
#include <iomanip>
#include <string>

using namespace std;

void printGrade(int oneScore, float average);

const int MAX_SIZE = 21;  //declared by professor

void readStudentData(ifstream &rss, int scores[], int id[], int &count, bool &tooMany)
{

	rss.open("studentData.txt",ios::in,ios::binary);

	count = 0;
	int oneScore = 0;
	float average = 0;
	string grade;

	if(rss.fail())
	{
		cout << "Cannot Open File. If test file has been \n"
			<< "created rename it studentScoreData." << endl << endl;
		exit(1);
	}
	else
	{
		while((rss >> id[count] && count < MAX_SIZE) && (rss >> scores[count] && count < MAX_SIZE))
		{
			count++;
		}
	}
}

float computeAverage(int scores[], int count[])
{
	float average = 0;
	int sum = 0;
	for(int i = 0; i < MAX_SIZE; i++)
	sum += scores[i];
	average = sum / MAX_SIZE;

	return 0;
}

void printTable(int scores[], int id[], int count)
{

	int oneScore = 0;
	float average = 0;
	string grade;

	cout << left << setw(9) << "ID#s" << setw(9) << "Scores" << setw(9) << "Grades" << endl << endl;

	printGrade(oneScore, average);

	for(int i = 0; i < MAX_SIZE; i++)
	{
		cout << left << setw(9) << id[i] << setw(9) << scores[i] << setw(9) << grade << endl;
	}


}

void printGrade(int oneScore, float average)  //can't figure out how to get this to work right.
{
	oneScore = 0;
	average = 0;
	int count[MAX_SIZE];
	int id[MAX_SIZE];
	int scores[MAX_SIZE];
	string grade;

	computeAverage(scores,count);

	for(oneScore = 0; oneScore < MAX_SIZE; oneScore++)
	{
		if(scores[oneScore] > average + 10)
		{
			grade = "outstanding";
		}
		else if(scores[oneScore] < average - 10)
		{
			grade = "unsatisfactory";
		}
		else
		{
			grade = "satisfactory";
		}

//  if I take this out of comment all it does is print a bunch of negative numbers and all say unsatisfactory.
//  I know that this is setup right because if I hardcode an array it will do it properly. However I can't get
//  this to work.  Any suggestions?
//		cout << left << setw(9) << id[oneScore] << setw(9) << scores[oneScore] << setw(9) << grade << endl;
	}
	
}

int main()
{
	ifstream rss;
	string line;
	int scores[MAX_SIZE];
	int id[MAX_SIZE];
	int count;
	bool tooMany;

	readStudentData(rss, scores, id, count, tooMany);

	if (tooMany=true)
	{
		printTable(scores,id,count);
		exit(1);
	}
	else
	{
		printTable(scores,id,count);
	}

	return 0;
}

[opessoa]

try this...

if(scores[oneScore] > (average + 10))
{
	grade = "outstanding";
}
else if(scores[oneScore] < (average - 10))
{
	grade = "unsatisfactory";
}
else
{
	grade = "satisfactory";
}

[firedraco]

That's not the problem...

1. The while loop is very bad, it may attempt to write to out of bound data space, it also looks really ugly
2. computeAverage, you are returning 0...I think you meant return average;
3. printgrade():

void printGrade(int oneScore, float average)  //why are you passing these? You just
{
	oneScore = 0; //set them to 0
	average = 0;
	int count[MAX_SIZE]; //these aren't initialized, so they are garbage
	int id[MAX_SIZE];
	int scores[MAX_SIZE];
	string grade; //???

	computeAverage(scores,count); //giving compute average garbage data

	for(oneScore = 0; oneScore < MAX_SIZE; oneScore++)
	{
		if(scores[oneScore] > average + 10) //these will work, but scores is garbage
		{
			grade = "outstanding";
		}
		else if(scores[oneScore] < average - 10)
		{
			grade = "unsatisfactory";
		}
		else
		{
			grade = "satisfactory";
		}

	}
	
}

[42ApX9L8]

Here is printGrade() slightly revised:

void printGrade(int oneScore, float average)
{
	int count[MAX_SIZE];
	int id[MAX_SIZE];
	int scores[MAX_SIZE];
	string grade;

	computeAverage(scores,count);

	for(oneScore = 0; oneScore < MAX_SIZE; oneScore++)
	{
		if(scores[oneScore] > average + 10)
		{
			grade = "outstanding";
		}
		else if(scores[oneScore] < average - 10)
		{
			grade = "unsatisfactory";
		}
		else
		{
			grade = "satisfactory";
		}

//		cout << left << setw(9) << id[oneScore] << setw(9) << scores[oneScore] << setw(9) << grade << endl;
	}
	
}

Scores is still garbage. Each function has parameters that it passes because that is what my book requires. If it were up to me I wouldn't have parameters and I would just have one long and ugly looking main function that did everything. However, it is not up to me. How can I get scores to equal what it is supposed to instead of being garbage?

[kempofighter]

scores is an unitialized array within the printGrade function. printTable needs to pass the array to printGrade and assuming that the file i/o was successful it should work. Reread firedraco's post. The revision that you made didn't take all of his advice into consideration.