GETLINE() FOR THE CITIES WITH SPACES.

[erod 03]

I'M TRYING TO USE THE GETLINE FUNCTION TO PASS IN THE CITIES THAT HAVE SPACES, I HAVE USED ALMOST EVERY SOLUTION OUT THERE BUT CANNOT GET A CODE TO WORK PLEASE HELP!

#include <iostream>
#include <string>
#include <algorithm>

using std:: cout;
using std:: cin;
using std:: endl;
using std:: string;
using std:: transform;
using namespace std;

int main ()
{
//Declare all variables
int totalSales = 0;
char doAgain = 'Y';
string cityArray[8] = {"ATLANTA","BUFFALO","CHICAGO","DALLAS","FORT WORTH","LOS ANGELES","MIAMI","NEW YORK"};
int salesAmount[8] = {0};
string cityName = "";
bool cityFound = false;
int money = 0;

while (doAgain == 'Y')
{
cout << "City Name: ";
cin >> cityName;
transform(cityName.begin(), cityName.end(), cityName.begin(), toupper);
cityFound = false;


for (int i = 0; i < 8; i++)
{
if (cityArray[i] == cityName)
{
cityFound = true;
// get amount from user
cout << "Enter sale amount: $";
cin >> money;
salesAmount[i] += money;


}
}
if (cityFound == false)
{
cout << "City " + cityName + " not found in list." << endl;
cout << "Do you want to search again: ";
cin >> doAgain;
doAgain = toupper(doAgain);
// Prompt try again
}//End if
}//End while
// Cout for loop.
for ( int i = 0; i < 8; i++)
{
cout << "Your City is: " << cityArray[i] << " and: " << salesAmount[i] << endl;
}
}

[Zhuge]

You are correct in needing getline, as I do not think cin>> works properly with an std::string.

getline(cin, MyString); //This is what you want.

[buffbill]

I couldn`t get your code to compile without commenting out the transform function. The transform function which I am aware of in <algorithm> is transform(p,q,pp,f) "It applies function f(x) to each x in p,q and copies the result into pp,pp+n where n=q-p."
If you could load 8 separate arrays with 1 city each from cityArray[8] it would seem a relatively simple exercise to cycle through each to find the spaces

[Duthomhas]

Argh, please use [code] tags. And don't shout.

Here is your program again, mostly repaired. Commentary follows below:

#include <iostream>
#include <string>
#include <algorithm>
#include <functional>
#include <limits>

using namespace std;

int main ()
  {
  //Declare all variables
  int totalSales = 0;
  char doAgain = 'Y';
  string cityArray[8] = {"ATLANTA","BUFFALO","CHICAGO","DALLAS","FORT WORTH","LOS ANGELES","MIAMI","NEW YORK"};
  int salesAmount[8] = {0};
  string cityName = "";
  bool cityFound = false;
  int money = 0;

  while (doAgain == 'Y')
    {
    cout << "City Name: ";
    getline( cin, cityName );
    transform(cityName.begin(), cityName.end(), cityName.begin(), ptr_fun <int,int> (toupper) );
    cityFound = false;

    for (int i = 0; i < 8; i++)
      {
      if (cityArray[i] == cityName)
        {
        cityFound = true;
        // get amount from user
        cout << "Enter sale amount: $";
        money = 0;
        cin >> money;
        cin.clear();
        cin.ignore( numeric_limits <streamsize> ::max(), '\n' );
        salesAmount[i] += money;
        }
      }

    if (cityFound == false)
      {
      cout << "City " + cityName + " not found in list." << endl;
      cout << "Do you want to search again: ";
      cin >> doAgain;
      cin.clear();
      cin.ignore( numeric_limits <streamsize> ::max(), '\n' );
      doAgain = toupper(doAgain);
      // Prompt try again
      }//End if

    }//End while

  // Cout for loop.
  for ( int i = 0; i < 8; i++)
    {
    cout << "Your City is: " << cityArray[i] << " and: " << salesAmount[i] << endl;
    }

  return 0;
  }

Lines 4 and 24
Alas, you cannot use toupper() directly with transform() because it is an overloaded function. So you must be careful to get an explicit pointer to the version of toupper() that you want. Do this using the <functional> classes, as indicated.

Line 23
Please use getline() with user input. The user always (and I cannot stress this enough -- but always) expects to deliver input (in this kind of application) by typing in his answer and finishing by pressing the Enter key. Your input methodology needs to match the user's expectations.

Remember, users only enter text. Get text from them, not ints or floats or whatever. Get the text, then transform it into the int or float or whatever.

Lines 5, 37, and 48
That said, however, there is a slightly different way of dealing with it: use the stream scanning as you were, then clear input to where the user pressed Enter. This resynchronizes the input stream to the same as if you had read a line of text directly.

Lines 34 - 37 and 46 - 48
There are caveats though -- since it is now possible for the user to give bad input (and set one of the fail bits) you must account it. What I have done is just minimal to prevent the program from crashing or looping forever on bad inputs. You should take more care to recognize bad inputs and bother the user for a correct one.

Well, I think I got every point. Hope this helps.

[buffbill]

You could also take this sort of approach:

int main()
{
    string  s1="Los Angeles";
    string  s2="Baltimore";
    string array[]={s1,s2};
    for(int i=0;i<3;i++)
    if((array[i].find(" "))< array[i].length())
    cout<<"name: "<<array[i]<<" ---> has a space\n";
    else cout<<"name: "<<array[i]<<" ---> has no space\n";
    
 system("pause");
 return 0;
}    

prints:
name: Los Angeles ---> has a space
name: Baltimore ---> has no space
Of course the experts will tell you that you should be using vectors not arrays but the same principle applies.
p.s. yuo shouldn`t use system("pause"); either as it is non portable across OS's