Did I code this class right?

[Lothp]

The code below runs when compiled, but I'm not sure if theName is saved as part of the object player1 which is an object of Character. Or if every time ShowName is called if it is just using the local variable.

#include <iostream>
#include <iomanip>
#include <fstream>
#include <string>
#include <ctime>
#include <cstdlib>
#include <cctype>
#include <cmath>
using namespace std;

// class declarations
class Character
{
  private:
    string name;
    int hitPoints;
	
  public:
    Character(string = "Thor", int = 100);
    void SetName(string);
    void ShowName(string);

};

Character::Character(string charName, int hp)
{
  name = charName;
  hitPoints = hp;
}

void Character::SetName(string newName)
{
  newName = name;

}  

void Character::ShowName(string name)
{
  cout << name;
}


int main()
{
  string theName;
  Character player1; // default values
  
  cout << "Enter player name:";
  getline(cin, theName);
  
  cout << "The next Hero to enter shall be called ";
  player1.ShowName(theName);
  cout << '!' <<endl;
  
  return 0;

}

Any help is appreciated.

[Zhuge]

Your set and show name methods are not logically correct, IMO. Your set name function should set the name inside the class equal to the parameter you are passing instead of the other way around. Your show name function should just print the class's name, not some random parameter you are passing to it.

[Lothp]

For show name would i do something like
cout << Character::Character.name

and do set name like this?
name = newName

also forgot novice programmer reporting in

[S G H]

class Character
{
  private:
    string name;
    int hitPoints;
	
  public:
    Character(string = "Thor", int = 100);
    void SetName(string);
    void ShowName(string); // Here

};

Check the line marked with "Here".
In that line, you're passing a std::string parameter you don't really need.
You want to print the hero's name, and you're storing that name inside your class.
You don't need it passed as a parameter.
You also are not editing anything in the class, so you can mark it as constant (const):

void ShowName() const;

You may also want to add some GetName/GetHp.

So, This

void Character::ShowName(string name)
{
  cout << name;
}

Becomes This:

void Character::ShowName() const
// const also goes there
{
  cout << name;
}

In this case, 'name' refers to 'this->name'.

Also, you did the opposite operation in SetName.

void Character::SetName(string newName)
{
  newName = name;
}

should be

void Character::SetName(string newName)
{
  name = newName;
}

Now for this, your code in 'int main()' will become:

// ...
getline(cin, theName);
player1.SetName(theName);
cout << "The next Hero to enter shall be called ";
player1.ShowName(theName);
cout << '!' << endl;

You can extend it a little bit by writing this somewhere out of the class and before 'int main()':
(You need GetName, and you need it marked const)
ostream& operator<<(ostream& out, const Character& x ) { return (out << x.GetName()); }

Personally, i'd write it like this:

class Character
{
  private:
    string name;
    int hitPoints;
	
  public:
    Character(string = "Thor", int = 100);

    void SetName(string);
    void SetHp(int);

    string GetName() const;
    int GetHp() const;

};

Character::Character(string newname, int hp)
{
    name = newname;
    hitPoints = hp;
}

void Character::SetName(string newname)
{
    name = newname;
}

void Character::SetHp(int hp)
{
    hitPoints = hp;
}

string Character::GetName() const
{
    return name;
}

int Character::GetHp() const
{
    return hitPoints;
}

ostream& operator<<(ostream& out, const Character& x ) { return (out << x.GetName()); }

int main()
{
    string theName;
    Character player1;

    cout << "Enter player name:";
    getline(cin, theName);
    player1.SetName(theName);

    cout << "The next Hero to enter shall be called " << player1 << '!' << endl;

    return 0;
}

Feel free to explore the code or ask questions about it
(Oh, and usually HP means Health Points, not Hit Points)
Those functions could even be inlined.

[Lothp]

Thanks, it's gonna take me awhile to look through all of this, but I'll return with any questions.
Also used to play Runescape a long time ago when health was called hit points before they changed it to constitution.