Could I have used any pointers to better this program?

[Tiger58]

If anyone cares to look over it, this is the program: (Well only the header and the class functions

Header File

#ifndef FISH_H
#define FISH_H
#include <iostream>
#include <string>
using namespace std;

struct Fish
{
	string fishType;
	double fishLen;
	double fishWeight;
	string actions;
};

class Fishing
{
	private:
		Fish fish;
	public:
		//Constructors
		Fishing();
		Fishing(string,double,double);
		//Mutator Functions
		void setFishType(string t)
		{ fish.fishType=t; }
		void setFishLen(double);
		void setFishWeight(double);
		void setActions(string a)
		{ fish.actions=a; }
		//Accessor Functions
		string getFishType()
		{ return fish.fishType; }
		double getFishLen()
		{ return fish.fishLen; }
		double getFishWeight()
		{ return fish.fishWeight; }
		string getActions()
		{ return fish.actions; }
		//Other
		void getWhatToDo();
		void display();

};

#endif 

Functions:

#include "Fish.h"

Fishing::Fishing()
{
	fish.fishType = fish.actions = "Default";
	fish.fishLen = fish.fishWeight = 0;
}

Fishing::Fishing(string type,double len, double wid)
{
	fish.fishType=type;
	fish.fishLen=len;
	fish.fishWeight=wid;
}

void Fishing::setFishLen(double l)
{	
	if(l>=0)
		fish.fishLen=l; 
	else
		fish.fishLen=1;
}

void Fishing::setFishWeight(double w)
{ 
	if(w>=0)
		fish.fishWeight=w; 
	else
		fish.fishWeight=1;
}

void Fishing::getWhatToDo()
{
	string type=fish.fishType;
	double len=fish.fishLen,
		   weight=fish.fishWeight;

	if(weight>=2)
	{
		if(type=="Sheepshead")
		{
			if(len<15)
				fish.actions="Throw Back";
			else if(len>=15 && len <=21)
				fish.actions="Keep";
			else
				fish.actions="Tag";
		}
		else if(type=="Red Drum")
		{
			if(len<20)
				fish.actions="Throw Back";
			else if(len>=20 && len <=28)
				fish.actions="Keep";
			else
				fish.actions="Tag";
		}
		else
		{
			if(len<16)
				fish.actions="Throw Back";
			else
				fish.actions="Keep";
		}
	}
	else
		fish.actions="Throw Back";
}

void Fishing::display()
{
	cout<<getFishType()<<", ";
	cout<<getFishLen()<<" inches, ";
	cout<<getFishWeight()<<" lbs, ";
	cout<<getActions()<<endl;
}

The thing is, we are on the section about pointers, but am I forced to use pointers here? I am just confused as to the whole variable/pointer usage, the teacher said we would now always have to use pointers for everything, but what if they are not needed?

[devonrevenge]

thats nice and simple readable code, I dont see where you need pointers, your teachers teaching you nicely.

Whats your code actually do to need pointers though?

[Tiger58]

Well we have to ask the user to enter the number of fish he wants to enter data for, that is when we have to use a pointer to make a dynamic array. The only reason I am confused is because of what he said, that we should now get used to using many pointers instead of regular variables.

I would enter the rest of the program here but it would be too long I think.

[Catfish3]

The only reason I am confused is because of what he said, that we should now get used to using many pointers instead of regular variables.

Relax. Pointers are a relic. In modern C++ (the 2011 standard, C++11, which you probably won't learn much about), you are encouraged to use smart pointers such as std::unique_ptr for dynamic memory allocation.

And where you can, you should use references instead of pointers.

And also, any self-respecting C++ programmer will use std::string instead of character arrays char[] and character pointers char*.

[Tiger58]

Fair enough, thanks for the confirmation