Help with poker game

[jgush3]

I have to make a sort of poker game where 5 random cards are selected. The user can choose to replace whichever cards, and then the program tells them what their hand is.

The problem I am having is the part where the user is asked to discard whichever cards they choose and they are replaced. I can make a for loop which asks the user which they want to discard, but I can't figure out how to get rid of those cards and replace them.

The user would have to input the face and suit and that card would have to be removed. If I can figure that out then replacing it shouldn't be too bad.

The program works fine without the discarding part.

#include "stdafx.h"
#include <iostream>
#include <ctime>
#include <string>
#include <cmath>
#include <cstdlib>
#include <fstream>
#include <cctype>

using namespace std;
short convert_value(string value); //converts card face to a value, 2=2, jack=11, king=13 etc.
bool straight(short value[]); //checks if cards make a straight
bool same_suit(string suit[]);//checks if cards make a flush
void check(bool& four, bool& three, bool& pair, bool& two_pair, short combos[], short& size); //checks if cards make 3 of a kind, pairs, etc.
void xx(short value[], short num_of_combos[], short& size);//checks for multiple occurences or something, dont really know, given to me by partner

int _tmain(int argc, _TCHAR* argv[])
{
	srand(time(NULL));
	string cardval[13];
	cardval[0]="A";
	cardval[1]="2";
	cardval[2]="3";
	cardval[3]="4";
	cardval[4]="5";
	cardval[5]="6";
	cardval[6]="7";
	cardval[7]="8";
	cardval[8]="9";
	cardval[9]="10";
	cardval[10]="J";
	cardval[11]="Q";
	cardval[12]="K";
	string suit[4];
	suit[0]="H";
	suit[1]="D";
	suit[2]="C";
	suit[3]="S";

	string card1val=cardval[rand()%13];
	string card1suit=suit[rand()%4];
	string card2val=cardval[rand()%13];
	string card2suit=suit[rand()%4];
	string card3val=cardval[rand()%13];
	string card3suit=suit[rand()%4];
	string card4val=cardval[rand()%13];
	string card4suit=suit[rand()%4];
	string card5val=cardval[rand()%13];
	string card5suit=suit[rand()%4];

	cout<<card1val<<" "<<card1suit<<endl;
	cout<<card2val<<" "<<card2suit<<endl;
	cout<<card3val<<" "<<card3suit<<endl;
	cout<<card4val<<" "<<card4suit<<endl;
	cout<<card5val<<" "<<card5suit<<endl;
	
	int x1=convert_value(card1val);
	int x2=convert_value(card2val);
	int x3=convert_value(card3val);
	int x4=convert_value(card4val);
	int x5=convert_value(card5val); 

	

	short value[]={x2,x2,x3,x4,x5};
	cout<<value[2]<<endl;
	
	short combos[5], size(0);
	xx(value, combos, size);
	bool pair(false), two_pair(false), three(false), four(false);
	check(four, three, pair, two_pair, combos, size);
	bool is_straight=straight(value);
	bool is_same=same_suit(suit);

	if(is_same && is_straight)
		{
			cout << "Straight Flush\n\n";
		}
		else if(is_straight)
		{
			cout << "Straight\n\n";
		}
		else if(four)
		{
			cout << "Four of a kind\n\n";
		}
		else if(three)
		{
			cout<<"Three of a kind\n\n";
		}
		else if(three && pair)
		{
			cout << "Full House\n\n";
		}
		else if(is_same)
		{
			cout << "Flush\n\n";
		}
		else if(two_pair)
		{
			cout << "Two pair\n\n";
		}
		else if(pair)
		{
			cout << "Pair\n\n";
		}
		else
		{
			cout << "No Winning Hand\n\n";
		}


	return 0;
}
short convert_value(string value)
{
	if(value == "2")
	{
		return 2;
	}
	else if(value == "3")
	{
		return 3;
	}
	else if(value == "4")
	{
		return 4;
	}
	else if(value == "5")
	{
		return 5;
	}
	else if(value == "6")
	{
		return 6;
	}
	else if(value == "7")
	{
		return 7;
	}
	else if(value == "8")
	{
		return 8;
	}
	else if(value == "9")
	{
		return 9;
	}
	else if(value == "10")
	{
		return 10;
	}
	else if(value == "Q")
	{
		return 11;
	}
	else if(value == "J")
	{
		return 12;
	}
	else if(value == "K")
	{
		return 13;
	}
	else//(value == "A")
	{
		return 14;
	}
}
bool straight(short value[])
{
	short min = value[0];
	for(short i = 1; i < 5; i++)
	{
		if(value[i] < min) 
		{
			min = value[i];
		}
	}

	short next = min + 1;
	short i = 0;
	while(i < 5)
	{
		if(value[i] == next)
		{
			next++;
			i=0;
		}
		else
		{
			i++;
		}
	}


	if(next == (min+5))
	{
		return true;
	}
	else
	{
		return false;
	}
}
bool same_suit(string suit[])
{
	string test=suit[0];
	for(short i=1; i<5; i++)
	{
		if(test!=suit[i])
		{
			return false;
		}
	}
	return true;
}
void check(bool& four, bool& three, bool& pair, bool& two_pair, short combos[], short& size)
{
	short pairs(0), threes(0), fours(0);
	for(short i = 0; i < size; i++)
	{
		if(combos[i] == 2)
		{
			pairs++;
		}
		if(combos[i] == 3)
		{
			three = true;
		}
		if(combos[i] == 4)
		{
			four = true;
		}
	}

	if(pairs == 2)
	{
		two_pair = true;
	}
	else if(pairs == 1)
	{
		pair = true;
	}

	return;
}
void xx(short value[], short combos[], short& size)
{
	short k = 0;
	short count;
	bool encountered[] = {false, false, false, false, false};
	for(short i = 0; i < 5; i++)
	{
		if(!encountered[i])
		{
			size++;
			encountered[i] = true;
			count = 1;
			for(short j = 1;  j < 5; j++)
			{
				if((!encountered[j]) && (value[i] == value[j]))
				{
					encountered[j] = true;
					count++;
				}
			}
			combos[k] = count;
			k++;
		}
	}
	return;
}

[CallMeCrazy]

I didn't take a too in-depth look at your code, so what I say below not be what you are looking for or might not help, but here goes.

With how you have it set up, you would probably have to add a bunch of if statements. As such below:

This assumes user has inputted what they want to remove and stored it in:
strings removeVal and removeSuit

if(card1val[0] == removeVal[0] && card1suit[0] == removeSuit[0]) {
     card1val=cardval[rand()%13];
     card1suit=suit[rand()%4];
}
else if(card2val[0] == removeVal[0] && card2suit[0] == removeSuit[0]) {
     card2val=cardval[rand()%13];
     card2suit=suit[rand()%4];
}
...
...
...
else if(card5val[0] == removeVal[0] && card5suit[0] == removeSuit[0]) {
     card5val=cardval[rand()%13];
     card5suit=suit[rand()%4];
}
else {
    //card not found
}

Just some random thoughts about your card game.
You are going to run into a problem where you can be dealt the same card two or more times (i.e., K of spades x 5, is it a flush, 5 of a kind, nobody knows)
If I were you, I would set card up as a structure like:

struct card {
     int val;
     char suit;
};
// Or whatever data types 

And, if you know how to use classes, this would be much simpler to code, imho. (a Deck class with an array of 52 cards to accurately reflect a deck, a shuffle function, and some other stuff) (and maybe even a Hand class that "holds" the cards you have been dealt)

[jgush3]

That helps alot thanks. And yea I knew I'd have a problem with multiple cards(on the off chance the same one gets generated twice). I have just learned structures but not classes yet. I will look into it. Thanks again