i can debug..but the pop() function did not pop the value that i wanted..it keep pop the last value that i insert!!!!!!

[B031110034]

#include<iostream>
using namespace std;
#define size 10


class stack
{
private:
int num;
int array[size];
int top;
public:
stack();
~stack();
void push(int data);
void pop(int &);
bool empty();
bool full();

};

stack::stack()
{
top=-1;
}

stack::~stack() {}


void stack::push(int data)
{
if(!full())
{
top++;
data=array[top] ;
}
else
cout<<"The stack is full!!"<<endl;
}

void stack::pop(int & data)
{
if(!empty())
{
top--;
array[top]=num;
cout<<num<<" ";
}
else
cout<<"The stack is empty!!"<<endl;

}

bool stack::empty()
{
if(top==-1)
return true;
else
return false;
}


bool stack::full()
{
if(top==size-1)
return true;
else
return false;
}


void main()
{
stack sample;
int num=99;
int data;

while(num!=0)
{
cout<<"Enter a number OR 0 to stop: ";
cin>>num;
sample.push(num);

}
cout<<"The data in reverse order is: ";
while(!sample.empty())
{
sample.pop(num);
}


}

[Volatile Pulse]

To help you out, here is your code

#include<iostream>
using namespace std;
#define size 10


class stack {
private:
    int num;
    int array[size];
    int top;
public:
    stack();
    ~stack();
    void push(int data);
    void pop(int &);
    bool empty();
    bool full();

};

stack::stack() {
    top=-1;
}

stack::~stack() {}


void stack::push(int data) {
    if(!full()) {
        top++;
        data=array[top] ;
    } else
        cout<<"The stack is full!!"<<endl;
}

void stack::pop(int & data) {
    if(!empty()) {
        top--;
        array[top]=num;
        cout<<num<<" ";
    } else
        cout<<"The stack is empty!!"<<endl;

}

bool stack::empty() {
    if(top==-1)
        return true;
    else
        return false;
}


bool stack::full() {
    if(top==size-1)
        return true;
    else
        return false;
}


int main() {
    stack sample;
    int num=99;
    int data;

    while(num!=0) {
        cout<<"Enter a number OR 0 to stop: ";
        cin>>num;
        sample.push(num);

    }
    cout<<"The data in reverse order is: ";
    while(!sample.empty()) {
        sample.pop(num);
    }

    return 0;
}

And these are the warnings

Code Blocks Compiler wrote:

C:\...\main.cpp|36|warning: unused parameter 'data'|
C:\...\main.cpp||In function 'int main()':|
C:\...\main.cpp|65|warning: unused variable 'data'|
||=== Build finished: 0 errors, 2 warnings ===|

Does that help?

[Volatile Pulse]

Also, in your stack, what does num do? I don't see if being used anywhere in your class. I believe you also have you assignment operators mixed up, for example
data=array[top] ; array[top]=num;

These should be switched.

I also don't think you want to add the 0 the user enters to the stack

    while(num!=0) {
        cout<<"Enter a number OR 0 to stop: ";
        cin>>num;
        sample.push(num);

    }

Should be

    while(num!=0) {
        cout<<"Enter a number OR 0 to stop: ";
        cin>>num;
        if (num != 0)
            sample.push(num);

    }

[B031110034]

although i change everything that u all suggested/ corrected ..but the pop output is still keep repeat the barbage(not the output tat i expected)!!

[Volatile Pulse]

...Works for me

#include<iostream>
using namespace std;
#define size 10


class stack {
private:
    int num;
    int array[size];
    int top;
public:
    stack();
    ~stack();
    void push(int data);
    void pop();
    bool empty();
    bool full();

};

stack::stack() {
    top=-1;
}

stack::~stack() {}


void stack::push(int data) {
    if(!full()) {
        top++;
        array[top] = data;
    } else
        cout<<"The stack is full!!"<<endl;
}

void stack::pop() {
    if(!empty()) {
        num = array[top];
        cout<<num<<" ";
        top--;
    } else
        cout<<"The stack is empty!!"<<endl;

}

bool stack::empty() {
    if(top==-1)
        return true;
    else
        return false;
}


bool stack::full() {
    if(top==size-1)
        return true;
    else
        return false;
}


int main() {
    stack sample;
    int num=99;

    while(num!=0) {
        cout<<"Enter a number OR 0 to stop: ";
        cin>>num;
        if (number != 0)
            sample.push(num);

    }
    cout<<"The data in reverse order is: ";
    while(!sample.empty()) {
        sample.pop();
    }

    return 0;
}

I entered 10,20,30,40,50,60,70,80,90,10,0
I got 10,90,80,70,60,50,40,30,20,10

[coder777]

You didn't understand what Volatile Pulse wrote.

Remove line 8.

Line 31/39 makes no sense.

[B031110034]

thank you!!!