Help with making a linked bribe list

[Dmitriy78]

Hi, I'm doing a linked list for a waiting list that is sorted by bribes (If student A pays 5 dollars and student B pays 6 dollars, student B will be in front of student A). For some reason, when I try to output my results I always receive an endless loop, where all I see is the very last student and his bribe being outputted over and over again. I have not yet written the Insert After function, so whenever I input numbers they are always bigger than the ones before (The purpose of Insert After is to insert the student and bribe, if the bribe is the lowest of all those inputted, at the end of the list.

Here is my header file:

#ifndef PERSON_H
#define PERSON_H

struct PersonRec
{
     char name[20];
	 int bribe;
	 PersonRec* link;
}
;
class PersonList {

public:
PersonList();
~PersonList();
void ViewList();
void AddToList ();

private:
PersonRec* head;
void Advance(PersonRec*);
void Reset(PersonRec*);
void PrevPtr(PersonRec*);
PersonRec* InsertBefore(PersonRec*,PersonRec*,PersonRec**);
void InsertAfter(PersonRec*,PersonRec*);
PersonRec* CurrRec();
/*
insert here other private member functions as you
see the need for them. However, you cannot add
any additional member variables or public
member functions than the four listed above
*/
};
#endif

//Here are my functions:

#include "personlist.h"
#include <iostream>
using namespace std;

PersonList::PersonList()
{
	head=NULL;
}
PersonList::~PersonList()
{
	for(head;head!=NULL;head=head->link)
	{
		delete head;
	}

}
PersonRec* PersonList::InsertBefore(PersonRec* aPtr,PersonRec* currPtr, PersonRec** currPtr2)
{
	PersonRec ** headPointer=&head;

	  PersonRec *temp = new PersonRec;
	  temp->bribe = currPtr->bribe;
          temp->link = currPtr->link;
          currPtr= aPtr;
	  currPtr->link=temp;

	  **currPtr2=*aPtr;
	  currPtr2=&(head->link);
	  **currPtr2=*currPtr;

	  **currPtr2=**headPointer;

	  return currPtr;
}
void PersonList::InsertAfter(PersonRec* a,PersonRec* b)
{

}
void PersonList::Reset(PersonRec* a)
{
	
	a=head;
}
void PersonList::ViewList()
{
	if(head==NULL)
	{
		
		cout<<"The list is empty. "<<endl;
	}
	else if(head!=NULL)
	{
		
		for(head;head!=NULL;head=head->link)
		{
		for(int x=0;x<20;x++)
		{
			cout<<head->name[x];
		}
		cout<<" "<<head->bribe;
		
		}
	}
}
void PersonList::Advance(PersonRec* currPtr)
{
	currPtr=currPtr->link;
}
void PersonList::AddToList()
{
PersonRec* aPtr=new PersonRec;
PersonRec** theHead=&head;

char aName[20];
int aBribe;
cout << "\nEnter the person's name: ";
cin.getline(aName, 20); 
cout<< "\nEnter the person's contribution: ";
cin >> aBribe;

aPtr->bribe=aBribe;
for(int x=0;x<20;x++)
{
	aPtr->name[x]=aName[x];
}

PersonRec* currPtr=new PersonRec;
PersonRec** currPtr2=&head;
currPtr=head;
if(head!=NULL)
{

while(currPtr!=NULL)
{
	if(currPtr->bribe < aPtr->bribe)
	{
		PersonRec *Checker=InsertBefore(aPtr,currPtr,currPtr2);
		cout<<Checker->bribe<<endl;
		cout<<Checker->name[0];
		cout<<Checker->name[1];
		cout<<head->bribe<<endl;
		cout<<head->name[0];
		cout<<head->name[1];
		currPtr=NULL;
	}
	else if(currPtr->bribe > aPtr->bribe)
	{
		Advance(currPtr);
	}

}
}
else
{
	head=aPtr;
	//head->link=NULL;
	
	
}
currPtr2=theHead;
}

//Here is my driver.
#include "PersonList.h"
#include <iostream>
using namespace std;

int displayMenu (void);
void processChoice(int, PersonList&);

int main ( )
{
int num;
PersonList myList;
do 
{
num = displayMenu();
if (num != 3)
processChoice(num, myList);
} while (num != 3);
return 0;
}

int displayMenu (void)
{
int choice;
cout << "\nMenu\n";
cout << "==============================\n\n";
cout << "1. Add student to waiting list\n";
cout << "2. View waiting list\n";
cout << "3. Exit program\n\n";
cout << "Please enter choice: ";
cin >> choice;
cin.ignore();
return choice;
}

void processChoice(int choice, PersonList& p)
{
switch (choice)
{
case 1: p.AddToList();
break;
case 2: p.ViewList();
break;
}
}

[cire]

Line 108, you allocate a new PersonRec in AddToList.
Line 124, you allocate a new PersonRec in AddToList.
Line 58, you allocate a new PersonRec in InsertBefore which is called from AddToList.

So, for one insertion, you potentially allocate 3 new nodes. Does that seem right to you?

ViewList should be const. Then the compiler could warn you about modifying head and leaking all your memory.

Advance is not correct. You only modify the local pointer. (It shouldn't be a member function anyway. It doesn't access any members.)

There is no need at all in AddToList for any pointers to pointers.

At no time do you modify any of the links for the (potentially 3) new PersonRecs you allocate in AddToList, so they all point to random places in memory.