Segmentation error help

[Krent]

Hello, I am working on a project for my C++ class and i am almost finished but i keep getting a segmentation error. I know what segmentation error means but i don't know what is causing it here. Any help would be appreciated and please try to explain it simply. The program reads in 5 words from the user, adds a word, then deletes a word all with strings and pointers.

here's my code...

i think the error occurs in line 97 because i added location... but how do i delete the slot dynamicArray[location] ?
------------------------------------------------------------------------

// This program implements a dynamic array of strings
// Problem 6, p521-522
// Spring Semester 2012

#include <iostream>
#include <string>
using namespace std;

void read5names(string* names, int size);
void displayNames(string* names, int size);
string* addEntry(string* dynamicArray, int &size, string newEntry);
string* deleteEntry(string* dynamicArray, int &size, string entryToDelete);
int findName(string* dynamicArray, int size, string entryToDelete);

int main()
{
  // declarations
  string* names;
  string newname;
  int size = 5;
  int i;
  names = new string[5];

  // read 5 names
  cout << "Enter 5 names, one per line\n";
  read5names(names, size);
  cout << "\n===== ORIGINAL LIST =====\n";
  displayNames(names, size);

  // add a name and resize
  cout << "\nEnter a new name to add\n";
  getline(cin, newname);
  names = addEntry(names, size, newname);
  cout << "\n===== LONGER LIST   =====\n";
  displayNames(names, size);

  // remove a name and resize - attempt 1
  cout << "\nEnter a name to delete\n";
  getline(cin, newname);
  names = deleteEntry(names, size, newname);
  cout << "\n===== SHORTER LIST  =====\n";
  displayNames(names, size);

  //  remove a name and resize - attempt 2
  cout << "\nEnter a name to delete that is NOT in the list\n";
  getline(cin, newname);
  names = deleteEntry(names, size, newname);
  cout << "\n===== FINAL LIST    =====\n";
  displayNames(names, size);
}

void displayNames(string* names, int size)
{
   for(int i=0; i<size; i++)
   {
      cout << *(names+i) << endl;
   }

}

void read5names(string* names, int size)
{
   for(int i=0; i<size; i++)
   {
      getline(cin, names[i]);
   }

}

string* addEntry(string* dynamicArray, int &size, string newEntry)
{
   // declare new array one element larger
   string* onelarger;
   onelarger = new string[size+1];
   // copy names over into new array
   for(int i=0; i<(size); i++)
   {
      onelarger[i] = *(dynamicArray+i);
   }
   // add the new name
   onelarger[5] = newEntry;
   // increase the size
   size = size+1;
   // delete the old array
   delete []dynamicArray;
   // return the pointer to the new array
   return onelarger;
}

string* deleteEntry(string* dynamicArray, int &size, string entryToDelete)
{
   // determine if entryToDelete is in the dynamicArray
   int location;  // location of the match
   location = findName(dynamicArray, size, entryToDelete);
   if (location >= 0 )
   { // name found. Now delete it.
      delete (dynamicArray+location);
     // declare new array one size smaller
      string* onesmaller;
      onesmaller = new string[size-1];
     // copy names over into new array
      for(int i=0; i<(size-1); i++)
      {
         onesmaller[i] = *(dynamicArray+i);
      }
     // decrement size
      size = size-1;
     // return the pointer to teh new array
      return onesmaller;
   }
   else
   { // name not found
      cout << entryToDelete << " not found!\n";
     // return the original array pointer
      return dynamicArray;
   }

}

int findName(string* dynamicArray, int size, string entryToDelete)
{
   int location = -1;
   for(int i=0; i< size; i++)
   {
      if(*(dynamicArray+i) == entryToDelete)
      {
         location=i;
      }
   }

   return location;

}

[cire]

Indeed, line 97 is a problem. You may only use delete on an address you obtain with new, and then it must be the corresponding delete[] for new[]'d memory.

The correct way to delete your entry is to allocate the smaller array, copy all but the entry you want to delete to the smaller array. delete[] the old array. return the new array.

Just fyi, you can write *(dynamicArray+i) as dynamicArray[i].

[Krent]

Thank you so much! I finished it thanks to your help. It turns out i didn't even need line 97 in the first place. lol.

Thank you!