how can i return to main?

[moe93]

Ok, The thing is I dont really know how to make a header file, so I gave it a shot and "tried" to make my own header for this big project am planing to make..=P

This is main.cpp:

#include <iostream>
#include "temperature.h"

using namespace std;

int main()
{
    int aio_choices;
    cout << "Please chose an option." << endl;
    cout << "1. Temperature Converter." << endl;
    cout << "2. COMING SOON." << endl;
    cout << ":.:>> ";
    cin >> aio_choices;

    if (aio_choices == 1)
    {
        tempmenue();
    }
    return 0;

and this is my header file (temperature.h):

#ifndef TEMPERATURE_H_INCLUDED
#define TEMPERATURE_H_INCLUDED

#include<iostream>
#include<windows.h>

using namespace std;

void tempmenue();
void dialogue();
int again();
int f2c();
int c2f();
int exit();

int exit()
{
    return 1;
}

int c2f()
{
    system ("CLS");
    int c;
    cout << "Enter the degree in Celsius.\n";
    cout << ":C:>> ";
    cin >> c;
    cout << ":F:=> " << c * 1.8 + 32 << endl;
    cin.get();
    again();
}

int f2c()
{
    system ("CLS");
    int f;
    cout << "Enter the degree in Fahrenheit.\n";
    cout << ":F:>> ";
    cin >> f;
    cout << ":C:=> " << f - 32 * 5 / 9 << endl;
    cin.get();
    again();
}

int again()
{
    int yn;
    cout << "Would you like to convert another degree?" << endl;
    cout << "1. Yes.\n";
    cout << "2. No.\n";
    cout << "3. Return to root menu.\n";
    cout << ":.:>> ";
    cin >> yn;

    if (yn == 1)
    {
        dialogue();
    }
    else if (yn == 2)
    {
        exit();
    }
    else if (yn == 3)
    {
       return 0;
    }
    else
    {
        cout << "You chose an invalid choice, Program will now terminate!!!";
        return 0;
    }
}

void dialogue()
{
    int choice;
    cout << "Please enter an invalid choice.\n" ;
    cout << "1. Fahrenheit to Celsius.\n" ;
    cout << "2. Celsius to Fahrenheit.\n" ;
    cout << "3. Return to root menu.\n" ;
    cout << "4. Exit.\n" ;
    cout << ":.:>> ";
    cin >> choice;

    if (choice == 1)
    {
        f2c();
    }
    else if (choice == 2)
    {
        c2f();
    }
    else if (choice == 3)
    {
        main();
    }
    else
    {
        exit();
    }
}

void tempmenue()
{
    system ("CLS");
    cout << "This Program allows you to convert between temperatures." << endl;
    dialogue();
}

#endif // TEMPERATURE_H_INCLUDED 

My problem is I cant return to my main.cpp from this part of the code:

void dialogue()
{
    int choice;
    cout << "Please enter an invalid choice.\n" ;
    cout << "1. Fahrenheit to Celsius.\n" ;
    cout << "2. Celsius to Fahrenheit.\n" ;
    cout << "3. Return to root menu.\n" ;
    cout << "4. Exit.\n" ;
    cout << ":.:>> ";
    cin >> choice;

    if (choice == 1)
    {
        f2c();
    }
    else if (choice == 2)
    {
        c2f();
    }
    else if (choice == 3)
    {
        main();
    }
    else
    {
        exit();
    }
}

Just as you guys know, am a really nooby guy in C++, so please go easy on me and dont give me harsh comments =P
And any recommendation is greatly appreciated..=)

EDIT: I use Code::Blocks 10.05

[appnerd]

Try a different compiler, nothing's wrong with your code.







I think......

[moe93]

Dunno..
I believe my header file has got something wrong with it!!

But am not really sure..=P

[Danny Toledo]

You have exit, which returns a value, in a void which. I though void wasn't allowed to return anything. (I'm new too, so it's just a guess).

[zb0S216C]

Why have you included Windows?

This is a pointless method:

int exit()
{
    return 1;
}

cf2( ); // Should return an int. Make it void if it doesn't return anything.

f2c( ); // Should return an int. Make it void if it doesn't return anything.

again( ); // Should return an int. Make it void if it doesn't return anything.

Why not integrate a loop instead of calling again( ) over and over?

Eventually, your code will return to main after the branching methods of tempmenue( ) return. Overall, no value is returned from tempmenue( ) because it's void.

else if (choice == 3)
{
    main();  // This call will mean that int main will be calling itself.
}

P.S: Your header is fine. Although, it's common to see methods and classes declared in a header and defined in a source file. aio_choices should be initialized before you use it, avoid using namespace std whenever possible; it causes namespace pollution.

No harshness intended.

Edit ---------------------------------8<-------------------------------------
I see methods that return values but the returning values are not processed whatsoever. Like I said, make methods void if they either return nothing or the return value is going to be ignored.

Instead of using multiple if conditions, use a switch condition( Cleaner by far ).

[moe93]

Thanks for your help, but could you explain me the declaring and defining classes and functions, because I dont really understand that part! Give me a small example if you dont mind..=)

[zb0S216C]

This should help: http://www.learncpp.com/cpp-tutorial/19-header-files/