Console shows up output is not there.

[ipak]

I am outputting some fractions which are stored in classes with two variables for numerator and denominator; however, the output I am requesting using cout is not showing and an empty console is showing up. I have no idea what is wrong as the code brings up no errors when compiling. When debugging i get the following messages:

'Exam 3 Homework C++.exe' (Win32): Loaded 'C:\Users\Inho Pak\Desktop\CS 36\Homework\Exam 3 Homework C++\Debug\Exam 3 Homework C++.exe'. Symbols loaded.
'Exam 3 Homework C++.exe' (Win32): Loaded 'C:\Windows\SysWOW64\ntdll.dll'. Cannot find or open the PDB file.
'Exam 3 Homework C++.exe' (Win32): Loaded 'C:\Windows\SysWOW64\kernel32.dll'. Cannot find or open the PDB file.
'Exam 3 Homework C++.exe' (Win32): Loaded 'C:\Windows\SysWOW64\KernelBase.dll'. Cannot find or open the PDB file.
'Exam 3 Homework C++.exe' (Win32): Loaded 'C:\Windows\SysWOW64\msvcp140d.dll'. Cannot find or open the PDB file.
'Exam 3 Homework C++.exe' (Win32): Loaded 'C:\Windows\SysWOW64\vcruntime140d.dll'. Cannot find or open the PDB file.
'Exam 3 Homework C++.exe' (Win32): Loaded 'C:\Windows\SysWOW64\ucrtbased.dll'. Cannot find or open the PDB file.
The thread 0x478 has exited with code -1073741510 (0xc000013a).
The thread 0x1638 has exited with code -1073741510 (0xc000013a).
The thread 0x1fe8 has exited with code -1073741510 (0xc000013a).
The program '[5856] Exam 3 Homework C++.exe' has exited with code -1073741510 (0xc000013a).

 #define _CRT_SECURE_NO_WARNINGS
#include<iostream>
#include<iomanip>
#include<string>
using namespace std;

class Frac
{
public:
	Frac(int = 1, int = 1);
	void reduce(Frac &);
	void add(Frac &, Frac &);
	void subtract(Frac &, Frac &);
	void multiply(Frac &, Frac &);
	void divide(Frac &, Frac &);
	void printOut();
	void reciprocal();

private:
	int num, den;
};

Frac::Frac(int a, int b)
{
	num = a;
	den = b;
	
	int c, d, gcd, r;
	c = num;
	d = den;

	r = a % b;

	while (r != 0)
	{
		c = d;
		c = r;
		r = c % d;
	}

	gcd = d;

	num = num / gcd;
	den = den / gcd;
}

void Frac::reduce(Frac &c)
{
	int a, b, gcd, r;
	a = c.num;
	b = c.den;

	r = a % b;

	while (r != 0)
	{
		a = b;
		b = r;
		r = a % b;	
	}

	gcd = b;
	
	c.num = c.num / gcd;
	c.den = c.den / gcd;

	//cout << num << "/" << den << endl;
	
}

void Frac::add(Frac &c , Frac &sum)
{
	sum.den = den * c.den;
	sum.num = (num * (sum.den / den)) + (c.num * (sum.den / c.den));
	
	reduce(sum);
}

void Frac::subtract(Frac &c, Frac &sub)
{
	sub.den = den * c.den;
	sub.num = (num * (sub.den / den)) - (c.num * (sub.den / c.den));

	reduce(sub);
}

void Frac::multiply(Frac &c, Frac &mul)
{
	mul.num = num * c.num;
	mul.den = den * c.den;

	reduce(mul);
}

void Frac::divide(Frac &c, Frac &div)
{
	div.num = num * c.den;
	div.den = den * c.num; 

	reduce(div);
}

void Frac::printOut()
{
	cout << num << "/" << den <<" ";
}

void Frac::reciprocal()
{
	int a;
	a = den;
	den = num;
	num = a;
}
int main()
{
	Frac a(40, 50), b(36, 72), sum(4, 4), subt(4, 4), mult(4, 4), div(4, 4);
	
	a.add(b, sum);
	cout << "The sum of ";
	a.printOut();
	cout << "& ";
	b.printOut();
	cout << " is: ";
	sum.printOut();
	cout << endl << endl;

	a.subtract(b, subt);
	cout << "The deduction of ";
	a.printOut();
	cout << "& ";
	b.printOut();
	cout << " is: ";
	subt.printOut();
	cout << endl << endl;
	
	a.multiply(b, mult);
	cout << "The product of ";
	a.printOut();
	cout << "& ";
	b.printOut();
	cout << " is: ";
	mult.printOut();
	cout << endl << endl;

	a.divide(b, div);
	cout << "The quotient of ";
	a.printOut();
	cout << "& ";
	b.printOut();
	cout << " is: ";
	div.printOut();
	cout << endl << endl;

	//a.subtract(num2, den2, subnum, subden);
	cout << "The reciprocal of ";
	a.printOut();
	cout << "& "; 
	b.printOut();
	cout << " is: ";
	a.reciprocal();
	b.reciprocal();
	a.printOut();
	cout << " & ";
	b.printOut();
	cout << endl << endl;

	system("PAUSE");
	return 0;
	
}

[jlb]

In your constructor, what is the following supposed to be doing?

	while (r != 0)
	{
		c = d;
		c = r;
		r = c % d;
	}

It seems to be an endless loop.

[ipak]

It's supposed to reduce a fraction using the Euclidean Algorithm. I got this issue when i was adding more objects of the same class rather than using integars to calculate the arithmetic calculations. The loop previously worked but when i add more objects of the class Frac I am getting no output in the console

[MikeyBoy]

What's the point of line 3 in that snippet? You immediately overwrite the value of c in line 4.

[Handy Andy]

Hello ipak,

To go along with what jlb is saying and just to see what is happening try using this:

r = a % b;

std::cout << "\n First value for r = " << r << std::endl; // <--- Used for testing. Comment or remove when finished.

while (r != 0)
{
	c = d;
	std::cout << "\n c = " << c << " in while loop.";

	c = r;
	std::cout << "\n c = " << c << " in while loop.";

	r = c % d;

	std::cout << "\n r = " << r << " in while loop."; // <--- Used for testing. Comment or remove when finished.

	std::cin.get(); // <--- Used for testing. Comment or remove when finished.
}

The "cout" statements help when testing.

Hope that helps,

Andy

[dhayden]

reduce() should take no arguments. It should just reduce the Frac that it's called on.

That whacky call in the constructor should be replaced with a call to reduce():

Frac::Frac(int a, int b)
{
    num = a;
    den = b;
    reduce();
}

Your function "results" are stored in function parameters. Why not have the functions return the results instead? E.g.:
Frac add(Frac &r); // return *this + r

Have you learned about operator overloading? with that, you can overload the << operator and do things like:

a.add(b,sum);
cout << "The sum of " << a << " and " << b << " is " << sum << endl;

You can even overload the arithmetic operators and make this:
cout << "The sum of " << a << " and " << b << " is " << a+b << endl;