min_max function

[georgiana muresan19]

How make a function that calculates the minimum and maximum of array and uses 2 reference type parameters to return the results?

int min_max(int n,int a[],int&mini,int &maxi)
{
mini=a[0];
maxi=a[0];
for (int i=1; i<n; i++)
{
if (mini>a[i])
mini=a[i];
if (maxi<a[i])
maxi=a[i];

}
return mini,maxi;

}

[Repeater]

Don't return anything. That's the point of using reference type parameters.

[georgiana muresan19]

then the function should be void?

[Repeater]

Sure should.

[georgiana muresan19]

void min_max(int n,int a[],int&mini,int &maxi)
{
mini=a[0];
maxi=a[0];
for (int i=1; i<n; i++)
{
if (mini>a[i])
mini=a[i];
if (maxi<a[i])
maxi=a[i];

}

}


it's ok?
how call the function in the main program?

[Repeater]

how call the function in the main program?

Have an int that is the size of the array.
Have the array of ints.
Have an int that will be the max value.
Have an int that will the the minimum value.

min_max( the_size_of_the_array, the_array, min_value, max_value);

How to call a function is fairly basic. Very, very basic in fact. This is definitely something you should already know if you intend to write functions.

[georgiana muresan19]

void min_max(int n,int a[],int&mini,int &maxi)
{
mini=a[0];
maxi=a[0];
for (int i=1; i<n; i++)
{
if (mini>a[i])
mini=a[i];
if (maxi<a[i])
maxi=a[i];

}
cout<<"minimul is"<<mini;
cout<<"maximul is "<<maxi;
}
int main()
{
int x,y,n,a[6];
citire(n,a);
min_max(n,a,mini,maxi);
return 0;
}



the program doesn't display what it should.

[Handy Andy]

Hello georgiana muresan19,

PLEASE ALWAYS USE CODE TAGS (the <> formatting button), to the right of this box, when posting code.

Along with the proper indenting it makes it easier to read your code and also easier to respond to your post.

http://www.cplusplus.com/articles/jEywvCM9/
http://www.cplusplus.com/articles/z13hAqkS/

Hint: You can edit your post, highlight your code and press the <> formatting button.
You can use the preview button at the bottom to see how it looks.

I found the second link to be the most help.

the program doesn't display what it should.

Not surprised.

The program does not compile and therefor can not be run.

Once I make it run-able I believe the if statements in the function are backwards. Sometimes the order of the if condition does make a difference.

I think that citire(n,a); may be a function to input the numbers, but since it is missing I am not sure.

It is usually best to post a complete program that will compile and run.

Hope that helps,

Andy

[georgiana muresan19]

This is code:

#include <iostream>

using namespace std;
void citire(int n,int a[])
{
    cout << "n=";
    cin >> n;
    for (int i = 0; i < n; i++)
    {
        cout << "a[" << i << "]=";
        cin >> a[i];
    }
}
void min_max(int n,int a[],int&mini,int &maxi)
{
    mini=a[0];
    maxi=a[0];
    for (int i=1; i<n; i++)
    {
        if (mini>a[i])
            mini=a[i];
        if (maxi<a[i])
            maxi=a[i];

    }
    cout<<"minimul este"<<mini;
    cout<<"maximul este "<<maxi;
}
int main()
{
    int x,y,n,a[6],mini,maxi;
    citire(n,a);
    min_max(n,a,mini,maxi);
    return 0;
}

[dhayden]

You need to pass n by reference to citire() so the value gets set in main() too.

It looks like that code will work, but let me make two suggestions to make to make it
cleaner and more useful.

First, min_max should set mini and maxi to the index of the min and max values, not the values themselves. Sometimes you want to know where the values occur, not just what they are.

Second, you should print the results in main() not in min_max(). That makes min_max more useful. It can be called for other purposes than just to print out the values.

#include <iostream>

using namespace std;
void citire(int &n,int a[])
{
    cout << "n=";
    cin >> n;
    for (int i = 0; i < n; i++)
    {
        cout << "a[" << i << "]=";
        cin >> a[i];
    }
}
void min_max(int n,int a[],int&mini,int &maxi)
{
    mini=0;
    maxi=0;
    for (int i=1; i<n; i++)
    {
        if (a[mini]>a[i])
            mini=i;
        if (a[maxi]<a[i])
            maxi=i;

    }
}
int main()
{
    int x,y,n,a[6],mini,maxi;
    citire(n,a);
    min_max(n,a,mini,maxi);
    cout<<"minimul este "<<a[mini] << '\n';
    cout<<"maximul este "<<a[maxi] << '\n';
    return 0;
}