Delimiter not working
For a project I have to pass data from a file into an HTML code. The delimiter is not working (\t) instead of selecting all data between tabs, it selects only some data in between tabs and messes up the whole form. Any help would be appreciated.
|
|
Hello aaronpeart,
It ould help if you include some or all, if small, so everyone knows what you are using and can test your program.
For me it is late, so I will have to dig into the program tomorrow morning.
I have written a program similar to this which might help
Andy
It ould help if you include some or all, if small, so everyone knows what you are using and can test your program.
For me it is late, so I will have to dig into the program tomorrow morning.
I have written a program similar to this which might help
Andy
Hey Andy, this is due tonight so unfortunately that wont help much. I would still like to hear what you have to say. But here is two lines from the .txt file
1515C Cisco Implementing Video Network Devices 2 3/14/2016 3/18/2016 8:30 AM 4:30 PM Eastern Time 5
5384G Deploying Cisco Basic and Advanced Wireless LANs v1.1 3/14/2016 3/18/2016 8:30 AM 4:30 PM Eastern Time 5
1515C Cisco Implementing Video Network Devices 2 3/14/2016 3/18/2016 8:30 AM 4:30 PM Eastern Time 5
5384G Deploying Cisco Basic and Advanced Wireless LANs v1.1 3/14/2016 3/18/2016 8:30 AM 4:30 PM Eastern Time 5
Your last getline() should probably use the default delimiter.
I'm only guessing because the file sample you posted doesn't have any tab characters since you failed to put the lines into code blocks to preserve the special characters.
I'm only guessing because the file sample you posted doesn't have any tab characters since you failed to put the lines into code blocks to preserve the special characters.
Hello aaronpeart,
Sorry I could not do much before your deadline.
Just to help you in the future.
Your header files is missing <string> and I added <iomanip>.
Lines 7 - 12 should be inside main and you should avoid using global variables unless they start with "constexpr" or "const" as these can not be changed.
Your prototypes are good and I think I see their use.
After you open the input file you need to check that it is open and in good order. The output does not need any verification because for an output file if the file does not exist it creates the file.
The first bit of output code, I think this might be the "head" function, I used the "setw()" to space the tags. The "setw"s are not perfect and still need some adjustment.
Line 43. This is not the best way to read a file.
I do not know why people teach this. This is a bad idea as it does not work the way you think it will. Generally by the time the while condition determines that "eof" has been reached you will have processed the last read twice and wondering why it shows up twice.
What happens is the while condition is checked and “eof” has not been set yet. After entering the while loop you read the last line or bit of information from the file process the information reach the bottom of the while loop. At this point “eof” has not been set yet and you return to the while condition which is still good. After entering the loop you try to read from the file, but now there is nothing left to read and “eof” is set, but you do nothing at this point to deal with the “eof” condition. So you process what information is in the variables from the last read before returning to the while condition where it finally detects the “eof”, but you have processed the last good read twice unless you have cleared the variables at the end of the while loop in which case the last process will be blank.
A more acceptable way of using the while loop is:
In the above example you can set up the while condition to read one variable, two or more variables or use “std::getline(?, str)” where ? could be from “std::cin” or from a file stream and “str” represents any “std::string” variable.
As you will in the while loop I added some "endl"s and for the last "getline" I removed the delimiter of "\t" because this is reading the end of the line which ends with "\n" not "\t". The default delimiter for "getline" is "\n". If I understood correctly this is reading the information into the proper variables.
After I adjusted the program I opened the output file in my browser and it made a nice table.
In the end it really does not make any difference how the output file is indented as long as the tags are correct.
For what it is worth when I did something like this I first started by writing the "html" code to get an idea of how to write the C++ code. In the end I divided up the "html" code into three sections. The first section included the lines "<DOCTYPE! HTML>" to the opening "<body>" tag. This mad it easy to read the input file and write it to the output file. The third section finished up the "html" code that would not change all the way down to the closing "html" tag.
For the second section this is what the program would put together based on reading a "csv" file that created most of the table.
After processing the second section and the doing the third section my program would finish with writing a bit of JavaScript at the end.
Next time do not wait until the end to ask a question. Give your self more time for the questions and answers.
This is the code I changed this morning. It is not perfect, but should be enough for ideas and what should be done. Be sure to read the comments I put in the code.
Almost forgot. You are missing some closing "tr" tags. Although this is not absolutely necessary it is good form and programming to include them.
Hope that gives you some ideas for the future,
Andy
Sorry I could not do much before your deadline.
Just to help you in the future.
Your header files is missing <string> and I added <iomanip>.
Lines 7 - 12 should be inside main and you should avoid using global variables unless they start with "constexpr" or "const" as these can not be changed.
Your prototypes are good and I think I see their use.
After you open the input file you need to check that it is open and in good order. The output does not need any verification because for an output file if the file does not exist it creates the file.
The first bit of output code, I think this might be the "head" function, I used the "setw()" to space the tags. The "setw"s are not perfect and still need some adjustment.
Line 43. This is not the best way to read a file.
while(!inFile.eof()) I do not know why people teach this. This is a bad idea as it does not work the way you think it will. Generally by the time the while condition determines that "eof" has been reached you will have processed the last read twice and wondering why it shows up twice.
What happens is the while condition is checked and “eof” has not been set yet. After entering the while loop you read the last line or bit of information from the file process the information reach the bottom of the while loop. At this point “eof” has not been set yet and you return to the while condition which is still good. After entering the loop you try to read from the file, but now there is nothing left to read and “eof” is set, but you do nothing at this point to deal with the “eof” condition. So you process what information is in the variables from the last read before returning to the while condition where it finally detects the “eof”, but you have processed the last good read twice unless you have cleared the variables at the end of the while loop in which case the last process will be blank.
A more acceptable way of using the while loop is:
|
|
In the above example you can set up the while condition to read one variable, two or more variables or use “std::getline(?, str)” where ? could be from “std::cin” or from a file stream and “str” represents any “std::string” variable.
As you will in the while loop I added some "endl"s and for the last "getline" I removed the delimiter of "\t" because this is reading the end of the line which ends with "\n" not "\t". The default delimiter for "getline" is "\n". If I understood correctly this is reading the information into the proper variables.
After I adjusted the program I opened the output file in my browser and it made a nice table.
In the end it really does not make any difference how the output file is indented as long as the tags are correct.
For what it is worth when I did something like this I first started by writing the "html" code to get an idea of how to write the C++ code. In the end I divided up the "html" code into three sections. The first section included the lines "<DOCTYPE! HTML>" to the opening "<body>" tag. This mad it easy to read the input file and write it to the output file. The third section finished up the "html" code that would not change all the way down to the closing "html" tag.
For the second section this is what the program would put together based on reading a "csv" file that created most of the table.
After processing the second section and the doing the third section my program would finish with writing a bit of JavaScript at the end.
Next time do not wait until the end to ask a question. Give your self more time for the questions and answers.
This is the code I changed this morning. It is not perfect, but should be enough for ideas and what should be done. Be sure to read the comments I put in the code.
|
|
Almost forgot. You are missing some closing "tr" tags. Although this is not absolutely necessary it is good form and programming to include them.
Hope that gives you some ideas for the future,
Andy
Hello aaronpeart,
What I did forget to mention is that I changed the input file changing some of the spaces to tabs, so the program would be able to read it. There is no point in posting the changes as you would not be able to tell the difference between spacea and a tab.
For the future a "csv" (comma separated value) file would make it easier to read a file.
A "csv" file would look like:
Because of the comma there is no need for a space after the comma.
Hope that helps,
Andy
What I did forget to mention is that I changed the input file changing some of the spaces to tabs, so the program would be able to read it. There is no point in posting the changes as you would not be able to tell the difference between spacea and a tab.
For the future a "csv" (comma separated value) file would make it easier to read a file.
A "csv" file would look like:
1515C,Cisco Implementing Video Network Devices 2,3/14/2016,3/18/2016,8:30 AM 4:30 PM Eastern Time,5 5384G,Deploying Cisco Basic and Advanced Wireless LANs v1.1,3/14/2016,3/18/2016,8:30 AM 4:30 PM Eastern Time,5 |
Because of the comma there is no need for a space after the comma.
Hope that helps,
Andy
Hello aaronpeart,
While I was playing with your program I realized that I was a bit off when using the 'setw"s. The "std::setw(4)" part is correct. I was thinking to far ahead and missed that the intent was to print 4 spaces or actually three spaces and something for a total length of four. So if the character you want to print is a space you would end up with four spaces the proper code should be:
This line
A couple more changes and this makes a very nice output of a "html" file.
Hope that helps,
Andy
While I was playing with your program I realized that I was a bit off when using the 'setw"s. The "std::setw(4)" part is correct. I was thinking to far ahead and missed that the intent was to print 4 spaces or actually three spaces and something for a total length of four. So if the character you want to print is a space you would end up with four spaces the proper code should be:
fout << std::setw(4) << ' ' << "<head>" << std::endl;. Notice the single space between the "setw" and "head". this will expand to four total spaces.This line
fout << std::setw(12) << ' ' << "</tr>" << std::endl; was after the while loop and I moved it into the while loop.A couple more changes and this makes a very nice output of a "html" file.
Hope that helps,
Andy
Topic archived. No new replies allowed.