Help with header C++

[jsbd29]

I've finish all the required part but sadly I've encountered errors on the (Sunday and Saturday part) during the run. * I was so close to the final result, can anybody guide/help me on my errors. Thank you and God Bless you.

The errors are with my output.

1a). Design and implement a class dayType that implements the day of the week in a program. The class dayType should store the day, such as Sun for Sunday. The program should be able to perform the following operations on an object of type dayType:

a. Set the day
b. Print the day
c. Return the day
d. Return the next day
e. Return the previous day
f. Calculate and return the day by adding certain days to the current day. For example if the current day is Monday and we add 4 days, the day to be returned is Friday. Similarly, if today is Tuesday and we add 13 days, the day to be returned is Monday.
g. Add the appropriate constructors.

1b). Then, write the definitions of the functions to implement the operations for the class dayType as defined in Programming above. Also, write a program to test various operations on this class.

The following are my Header file, Implementation file and Main file.

#include <iostream>
#include<string>  

using namespace std; 

 class dayType  {
 	public:  
	void print()  const;  
	void setDay(string day);     
	int getPrevDay(); 
	int getNextDay();
	void randDay(int num);
	dayType();  
	dayType(string day);
	private:  
    int num;
	string today; 
	string prevDay;
	string nextDay;
};


void dayType::print()  const  
{  
	cout<< "Today is: "<< today <<endl;  
}  
void dayType::setDay(string day)  
{ 
    
	if ((day == "Monday") || (day == "monday"))
	{
		num=0;
		today=day;	
	}
	else if ((day == "Tuesday") || (day == "tuesday"))
	{
		num=1;
		today=day;	
	}
	else if ((day == "Wednesday") || (day == "wednesday"))
	{
		num=2;
		today=day;	
	}
	else if ((day == "Thursday") || (day == "thursday"))
	{
		num=3;
		today=day;	
	}
	else if ((day == "Friday") || (day == "friday"))
	{
		num=4;
		today=day;	
	}
	else if ((day == "Saturday") || (day == "saturday"))
	{
		num=5;
		today=day;	
	}
	else if ((day == "Sunday") || (day == "sunday"))
	{
		num=6;
		today=day;	
	}
	else
	    cout<<"Not a valid day. "<<endl;

	
}   
int dayType::getPrevDay()    
{  
     num--;
	return num;  
} 
int dayType::getNextDay() 
{
     num++;
	return num;
}

 //Defaultconstructor  
dayType::dayType()  
{ 
	today = "";  
 
}  
//Constructorwithparameters 
dayType::dayType(string day)  
{
	string today;
	day = today;  
}
void randDay(int num)
{	
	int random, add;
	cout << "How many days would you like to add to the current day? ";
	cin >> add;
	if (add > 6)
	{
		random = num + add / 7;
	}
	else
	random = num + add;
	
		if (random==0) 
	{
	   cout << "In " << add << " days, it will be " << "Sunday";
	}
	else if (random==1)
	{
	    cout << "In " << add << " days, it will be " << "Monday";
	}
	else if (random==2)
	{
	   cout << "In " << add << " days, it will be " << "Tuesday";
	}
	else if (random==3)
	{
		cout << "In " << add << " days, it will be " << "Wednesday";
	}
	else if (random ==4)
	{
		cout << "In " << add << " days, it will be " << "Thursday";
	}
	else if (random == 5)
	{
		cout << "In " << add << " days, it will be " << "Friday";
	}
	else 
		cout << "In " << add << " days, it will be " << "Saturday";
	
}

int main()
{
	string today;
	int dayNum, numDay, newNum;


	cout << "Enter the current day of the week: ";
	cin >> today;
	
	dayType week;
	week.setDay(today);
	dayNum = week.getPrevDay();
	numDay = week.getNextDay();
	newNum = week.getNextDay();

	cout<<"Yesterday was: ";
	if (dayNum==0) 
	{
	    cout<< "Monday" << endl;
	}
	else if (dayNum==1)
	{
	    cout<< "Tuesday" << endl;
	}
	else if (dayNum==2)
	{
	    cout<< "Wednesday" << endl;
	}
	else if (dayNum==3)
	{
		cout << "Thursday" << endl;
	}
	else if (dayNum ==4)
	{
		cout << "Friday" << endl;
	}
	else if (dayNum == 5)
	{
		cout << "Saturday" << endl;
	}
	else 
		cout << "Sunday" << endl;
		
	week.print();

	cout<<"Tomorrow is: ";
	if (numDay==0) 
	{
	    cout<< "Tuesday" << endl;
	}
	else if (numDay==1)
	{
	    cout<< "Wednesday" << endl;
	}
	else if (numDay==2)
	{
	    cout<< "Thursday" << endl;
	}
	else if (numDay==3)
	{
		cout << "Friday" << endl;
	}
	else if (numDay ==4)
	{
		cout << "Saturday" << endl;
	}
	else if (numDay == 5)
	{
		cout << "Sunday" << endl;
	}
	else 
		cout << "Monday" << endl;
		
	randDay(newNum);

	
	
	
	return 0;	
}

[keskiverto]

What is the observed problem?
* Fails to compile?
* Crash on run?
* Unexpected result?

At least line 74 is suspicious.

[Handy Andy]

Hello jsbd29,

PLEASE ALWAYS USE CODE TAGS (the <> formatting button) when posting code.
It makes it easier to read your code and also easier to respond to your post.
http://www.cplusplus.com/articles/jEywvCM9/
http://www.cplusplus.com/articles/z13hAqkS/
Hint: You can edit your post, highlight your code and press the <> formatting button.
You can use the preview button at the bottom to see how it looks.

Your program did compile, but after some checking I did find some problems.

In main:

int d{}, p{}, n{};  // <--- Good practice to initialize your variables.
//declare the class object
dayType obj;

//Prompt and read the input day
std::cout << " Enter the number:\n 1 - Monday "  // <--- Added "\n". Monday should be on its own line.
	<< "\n 2 - Tuesday"  // <--- Formatting needs to be consistent.
	<< "\n 3 - Wednesday"
	<< "\n 4 - Thursday"
	<< "\n 5 - Friday"
	<< "\n 6 - Saturday"
	<< "\n 7 - Sunday \n";  // <--- Added second "\n".
	// <--- Needs an option to quit.

//prompt the input day
std::cout << " Enter day: ";
std::cin >> d;

// <--- Needs  check here to end the program. 

Still looking into the rest of main, but some parts d not seem right.

In the header file:
Header files are in the wrong place. They should be in the main file with "main".

"using namespace std;" should never be in a header file.
http://www.lonecpluspluscoder.com/2012/09/22/i-dont-want-to-see-another-using-namespace-xxx-in-a-header-file-ever-again/ good reading.

For the class this:

class dayType
{
public: int presday;
		int prevday;
		int nextday;
		//Constructor
		dayType()
		{
			presday = 0;
			nextday = 0;
			prevday = 0;
		}
		//Member function declarations
		void set(int day);
		void print(int day);
		int Next_day(int pres);
		int Add_Next_days(int day);
		int day();
		int Prev_day(int pres);
};

Should be this:

//Class declaration
class dayType
{
	public:
		//Constructor
		dayType()
		{
			presday = 0;
			nextday = 0;
			prevday = 0;
		}
		//Member function declarations
		void set(int day);
		void print(int day);
		int Next_day(int pres);
		int Add_Next_days(int day);
		int day();
		int Prev_day(int pres);

	private:
		int presday;
		int prevday;
		int nextday;
};

Otherwise you defeat the purpose of the class.

In the "void dayType::print(int d)" function:
Each cout statement would look better if it ended with a "\n"

You are missing if (d == 5) , so "Friday" always prints.

After that I will point out that you include "<iomanip>, but never make use of all that is available. Some of the print calls use a "\t" in the previous cout and spacing is not always the best with a tab. The use of "std::setw()" wuld work better.

Hope that helps,

Andy

[jsbd29]

Thank You Andy! I works now . I am having problems to create the header.h