Can't delete a Node from the Binary Search Tree

My header file
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
#include <iostream>
#include <string>

using namespace std;

class BinaryTree
{
private:
	class btNode
	{
	public:
		int key;
		btNode *left;
		btNode *right;
	};

	btNode *root;

	btNode *CreateLeaf(int _key);
	void AddLeafPrivate(int _key, btNode *btPtr);
	void printInOrderPrivate(btNode *btPtr);
	btNode *ReturnNodePrivate(int _key, btNode *btPtr);

	int FindSmallestPrivate(btNode *btPtr);
	int FindMaximumPrivate(btNode *btPtr);

	btNode *deletePrivate(btNode *btPtr, int _key);

public:
	BinaryTree();

	void AddLeaf(int _key);
	void printInOrder();
	btNode *ReturnNode(int _key);
	int FindSmallest();
	int FindMaximum();
	void deleteNode(int _key);

	~BinaryTree();
};


My function definition file. Delete function is declared is defined at the top
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
#include "BST.h"

void BinaryTree::deleteNode(int _key)
{
	deletePrivate(root, _key);
}

BinaryTree::btNode* BinaryTree::deletePrivate(btNode *btPtr, int _key)
{
	if (root == NULL)
	{
		return root;
	}
	else if (_key < root->key)								//Traverse to the left side if key is smaller
	{
		root->left = deletePrivate(root->left, _key);
	}
	else if (_key > root->key)								//Traverse to the right side if key is greater
	{
		root->right = deletePrivate(root->right, _key);
	}
	else													//The key has been found
	{
		//Case 1 : No child
		if ((root->left == NULL) && (root->right == NULL))
		{
			delete root;
			root = NULL;
		}
		//Case 2 : One child
		else if (root->left == NULL)
		{
			btNode *temp = root;
			root = root->right;
			delete temp;
		}
		else if (root->right == NULL)
		{
			int temp = FindSmallest();
			root->key = temp;
			root->right = deletePrivate(root->right, temp);
		}
	}

	return root;
}

BinaryTree::BinaryTree()
{
	root = NULL;
};

BinaryTree::btNode* BinaryTree::CreateLeaf(int _key)
{
	btNode *temp = new btNode;

	temp->key = _key;
	temp->left = temp->right = NULL;

	return temp;
}

void BinaryTree::AddLeaf(int _key)
{
	AddLeafPrivate(_key, root);
}

void BinaryTree::AddLeafPrivate(int _key, btNode *btPtr)
{
	if (root == NULL)
	{
		root = CreateLeaf(_key);
	}
	else if (_key < btPtr->key)		//if value is smaller
	{
		if (btPtr->left != NULL)
		{
			AddLeafPrivate(_key, btPtr->left);
		}
		else
		{
			btPtr->left = CreateLeaf(_key);
		}
	}
	else if (_key > btPtr->key)		//if value is greater
	{
		if (btPtr->right != NULL)
		{
			AddLeafPrivate(_key, btPtr->right);
		}
		else
		{
			btPtr->right = CreateLeaf(_key);
		}
	}
	else
	{
		cout << "The key " << _key << " is already present in the tree" << endl;
	}
}

void BinaryTree::printInOrder()
{
	printInOrderPrivate(root);
}

void BinaryTree::printInOrderPrivate(btNode *btPtr)
{
	if (btPtr)
	{
		if (btPtr->left != NULL)
		{
			printInOrderPrivate(btPtr->left);
		}

			cout << btPtr->key << " ";
		
		if (btPtr->right != NULL)
		{
			printInOrderPrivate(btPtr->right);
		}
	}
	else
	{
		cout << "Tree is empty" << endl;
	}
}

BinaryTree::btNode* BinaryTree::ReturnNode(int _key)
{
	return ReturnNodePrivate(_key, root);
}

BinaryTree::btNode* BinaryTree::ReturnNodePrivate(int _key, btNode *btPtr)
{
	if (btPtr != NULL)
	{
		if (btPtr->key == _key)
		{
			return btPtr;
		}
		else
		{
			if (_key < btPtr->key)
			{
				return ReturnNodePrivate(_key, btPtr->left);
			}
			else
			{
				return ReturnNodePrivate(_key, btPtr->right);
			}
		}
	}
	else
	{
		return NULL;
	}
}

int BinaryTree::FindSmallest()
{
	return FindSmallestPrivate(root);
}

int BinaryTree::FindSmallestPrivate(btNode *btPtr)
{
	if (root == NULL)
	{
		cout << "The tree is empty" << endl;
		
		return NULL;
	}
	else
	{
		if (btPtr->left != NULL)
		{
			return FindSmallestPrivate(btPtr->left);
		}
		else
		{
			return btPtr->key;
		}
	}
}

int BinaryTree::FindMaximum()
{
	return FindMaximumPrivate(root);
}

int BinaryTree::FindMaximumPrivate(btNode *btPtr)
{
	if (root == NULL)
	{
		cout << "The tree is empty" << endl;

		return NULL;
	}
	else
	{
		if (btPtr->right != NULL)
		{
			return FindMaximumPrivate(btPtr->right);
		}
		else
		{
			return btPtr->key;
		}
	}
}


BinaryTree::~BinaryTree()
{
	cout << "Destructor is called" << endl;
}


My main file
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
#include "BST.h"

int main()
{
	int TreeKeys[16] = { 50, 76, 21, 4, 32, 64, 15, 52, 14, 100, 83, 2, 3, 70, 87, 80 };
	
	BinaryTree myTree;

	for (int i = 0; i < 16; i++)
	{
		myTree.AddLeaf(TreeKeys[i]);
	}

	myTree.printInOrder();

	cout << endl;

	cout << myTree.FindSmallest() << endl;
	cout << myTree.FindMaximum() << endl;

	myTree.deleteNode(2);

	myTree.printInOrder();

	system("pause");
	return 0;
}


The program crashes after i try to delete a node.
The node pointer being passed into the delete function is called btPtr, but the function is checking the pointer root instead of btPtr. There's infinite recursion of the function.

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
BinaryTree::btNode* BinaryTree::deletePrivate(btNode *btPtr, int _key)
{
	if (root == NULL)
	{
		return root;
	}
	else if (_key < root->key)								//Traverse to the left side if key is smaller
	{
		root->left = deletePrivate(root->left, _key);
	}
	else if (_key > root->key)								//Traverse to the right side if key is greater
	{
		root->right = deletePrivate(root->right, _key);
	}
	else													//The key has been found
	{
		//Case 1 : No child
		if ((root->left == NULL) && (root->right == NULL))
		{
			delete root;
			root = NULL;
		}
		//Case 2 : One child
		else if (root->left == NULL)
		{
			btNode *temp = root;
			root = root->right;
			delete temp;
		}
		else if (root->right == NULL)
		{
			int temp = FindSmallest();
			root->key = temp;
			root->right = deletePrivate(root->right, temp);
		}
	}

	return root;
}
Topic archived. No new replies allowed.