Why isn't my vector code working?

[Mboxer511]

I have this one line of code that gets and error and I don't know why. I'm making a menu that pulls up a .txt file of student information and then displays it based on a menu search. It utilizes vectors. The line with error is when my switch statement begins. Its typed as "switch (choice)" right before the opening bracket on line 35. Below is the code. Any help is appreciated. Thanks.

  /* 

	This is a program that utilizes vectors and sorting to print out 4 instances of student information based on first name, last name, gpa and major.

	StudentMain.cpp

*/

#include <iostream>
#include <fstream>
#include <string>
#include <vector> // declares the vector
#include "Student.h"
using namespace std;

void fill(vector<Student> &v, int &l);
void printMenu();
void sortBylName(vector<Student> &v);
void sortByMajor(vector<Student> &v);
void sortByGPA(vector<Student> &v);
void searchByName(vector<Student> &v, string fn, string ln, int l);

int main()
{
	vector<Student> vec(10, Student());	// Here a vector with a size of 10 is filled with type Student
	string lastName, firstName, Major;
	double GPA;
	int length = 0;
	int choice;

	do
	{
		printMenu();
		// Below is a switch that will display the menu for the user
		switch (choice)
		{
		case 1: fill(vec, length);
			int temp = vec.size() - length;

			for (int i = temp; i < vec.size(); i++)
			{
				vec[i].print();
			}
			cout << endl;

		case 2: sortBylName(vec);

			int temp = vec.size() - length;

			for (int i = temp; i < vec.size(); i++)
			{
				vec[i].print();
			}
			cout << endl;
		case 3:
			sortByGPA(vec);

			int temp = vec.size() - length;

			for (int i = temp; i < vec.size(); i++)
			{
				vec[i].print();
			}
			cout << endl;
		case 4:
			sortByMajor(vec);

			int temp = vec.size() - length;

			for (int i = temp; i < vec.size(); i++)
			{
				vec[i].print();
			}
			cout << endl;
		case 5:
			cout << "Enter the Student first and last name you would like to search: ";
			cin >> firstName >> lastName;
			cout << endl;

		case 6:
			cout << "Enter the Student Firstname:" << endl;
			cin >> firstName;
			cout << "Enter the Student Lastname:" << endl;
			cin >> lastName;
			cout << "Enter the Student GPA:" << endl;
			cin >> GPA;
			cout << "Enter the Student Major:" << endl;
			cin >> Major;

			Student s1(lastName, firstName, Major, GPA);

			vec.push_back(s1);
			length++;

			fill(vec, length);
		case 7:
			cout << "Please Enter the First and Last Name of the Student You Would Like to Search For: ";
			cin >> firstName >> lastName;
			cout << endl;
			searchByName(vec, firstName, lastName, length);

			Student s2(lastName, firstName, Major, GPA);

		default:
			cout << "Invalid Entry";
		}
	} while (choice < 0);

	cout << "Please Enter the Student's First Name: " << endl;
	cin >> firstName;
	cout << "Please Enter the Student's Last Name: " << endl;
	cin >> lastName;
	cout << "Please Enter the Student's GPA: " << endl;
	cin >> GPA;
	cout << "Please Enter the Student's Major: " << endl;
	cin >> Major;

	Student s1(lastName, firstName, Major, GPA);
	vec.push_back(s1); // This adds a new element at the end of the vector
	length++;

	fill(vec, length);
	sortBylName(vec);

	int temp = vec.size() - length;

	for (int i = temp; i < vec.size(); i++)
	{
		vec[i].print();
	}
	cout << endl;

	system("pause");
	return 0;
}

void printMenu()
{
	cout << "1. Display the Student List" << endl;
	cout << "2. Sort List by Last Name" << endl;
	cout << "3. Sort List by GPA" << endl;
	cout << "4. Sort List by Major" << endl;
	cout << "5. Search by Name" << endl;
	cout << "6. Add Student Data" << endl;
	cout << "7. Remove Student Data" << endl;
}

void fill(vector<Student> &v, int &l)
{
	ifstream inFile;
	inFile.open("students.txt");
	string strlName, strfName, strMajor;
	double GPA;

	while (!inFile.eof())
	{
		inFile >> strlName >> strfName >> GPA >> strMajor;

		Student temp(strlName, strfName, strMajor, GPA);

		v.push_back(temp);
		l++;
	}

	inFile.close();

}


void sortBylName(vector<Student> &v)
{
	Student temp;
	int location;

	for (int i = 1; i < v.size(); i++)
	{
		if (v[i].getlName() < v[i - 1].getlName())
		{
			temp = v[i];
			location = i;

			do
			{
				v[i] = v[location - 1];
				location--;
			} while (location > 0 && v[location - 1].getlName() > temp.getlName());

			v[location] = temp;
		}
	}

}

void sortByMajor(vector<Student> &v)
{
	Student temp;
	int location;

	for (int i = 1; i < v.size(); i++)
	{
		if (v[i].getmajor() < v[i - 1].getmajor())
		{
			temp = v[i];
			location = i;

			do
			{
				v[i] = v[location - 1];
				location--;
			} while (location > 0 && v[location - 1].getmajor() > temp.getmajor());

			v[location] = temp;
		}
	}

}

void sortByGPA(vector<Student> &v)
{
	Student temp;
	int location;

	for (int i = 1; i < v.size(); i++)
	{
		if (v[i].getgpa < v[i - 1].getgpa())
		{
			temp = v[i];
			location = i;

			do
			{
				v[i] = v[location - 1];
				location--;
			} while (location > 0 && v[location - 1].getgpa() > temp.getgpa());

			v[location] = temp;
		}
	}

}

void searchByName(vector<Student> &v, string fn, string ln, int l)
{

	bool found = false;

	int temp = v.size() - l;

	for (int i = temp; i < v.size(); i++)
	{
		if (v[i].getlName() == ln)
		{
			if (v[i].getfName() == fn)
			{
				found = true;
				cout << "The Student " << fn << " " << ln << "is at position " << i << endl;
				v[i].print();
				return;
			}
		}
	}

	if (found = false)
		cout << "The Student does not exist" << endl;
}

[coder777]

I'm guessing that you are talking about an error like this

41:8: error: crosses initialization of 'int temp'

?

You cannot have a local variable in a case branch of a switch. You need to encompass with braces:

		case 1: fill(vec, length);
		{ // Note
			int temp = vec.size() - length;

			for (int i = temp; i < vec.size(); i++)
			{
				vec[i].print();
			}
			cout << endl;
		} // Note
		break; // Note: To end the case you need a break, othewise it will continue with the next case (case 2:)