Text analyzer not generating the correct results.

[drmaniac]

Greetings. I'm trying to make a simple program that takes a string, counts how many times each character appears and gives a percentage compared to the total. It also counts the number of words and the occurrence of a three letter sequence "ted".

#include <iostream>
#include <string>

using namespace std;

int charcount(char a[],char k,int size)
{
	int c=0;

	for(int i=0;i<size;i++)
	{
		if (a[i]==k)
			c++;
		

	}



	return c;

}

int tedcount(char a[],int size)
{
	int c=0;
	for (int i=0;i<size;i++)
	{
		if ((a[i]=='t'||a[i]=='T')&&(a[i+1]=='e'||a[i+1]=='E')&&(a[i+2]=='d'||a[i+2]=='D'))
		{
			c++;
		}

		


	}



	return c;

}

int wordcount(const char* ca)
{
   if (ca == NULL)
      return 0;

   bool inSpaces = true;
   int numWords = 0;

   while (*ca != NULL)
   {
      if (isspace(*ca))
      {
         inSpaces = true;
      }
      else if (inSpaces)
      {
         numWords++;
         inSpaces = false;
      }

      ++ca;
   }

   return numWords;
}


int main()
{
	string input;
	int lcount[96];
	float total=0,total2=0,maxtotal,tedtotal,wc,tc;
	for(int i=0;i<94;i++)
	{
		lcount[i]=0;

	}

	cout<<"please enter the characters to be counted"<<endl;
	getline(cin,input);


	char *t= new char[input.size()+1];
	int size=input.size();
	t[input.size()]=0;
	memcpy(t,input.c_str(),input.size());
	char carray[91]={'a','b','c','d','e','f','g','h','i','j','k','l','m','n','o','p','q','r','s','t','u','v','w','x','y','z','A','B','C','D','E','F','G','H','I','J','K','L','M','N','O','P','Q','R','S','T','U','V','W','X','Y','Z','1','2','3','4','5','6','7','8','9','0','~','`','!','@','#','$','%','^','&','*','(',')','_','-','=','+','[','{','}',']','|','\\','/','<','>',',','.','?','/'};


	for(int i=0;i<size;i++)
	{

		lcount[i]=charcount(t,carray[i],size);

		
	}

	for (int i=0;i<62;i++)
	{
		total=lcount[i]+total;

}
	for (int i=63;i<91;i++)
	{
		total2=lcount[i]+total2;

}

	maxtotal=total+total2;

	for(int i=0;i<62;i++)
	{
		
		cout<<"Character:"<<carray[i]<<"  Count "<<lcount[i]<<endl;
		cout<<" total frequency %"<<(lcount[i]/maxtotal)*100<<endl;
		cout<<" alphanumeric only % "<<(lcount[i]/total)*100<<endl;
		cout<<"-----------------------------------------"<<endl;
		
	}

	for(int i=63;i<91;i++)
	{

		
	cout<<"Character:"<<carray[i]<<"  Count "<<lcount[i]<< " total frequency %"<<(lcount[i]/maxtotal)<<endl;
		

	}
	cout<<"------------------------------------"<<endl;

	wc=wordcount(t);
	tc=tedcount(t,size);
	tedtotal=(tc/wc)*100;
	cout<<"total number of characters:"<<maxtotal<<endl;
	cout<<"Number of words is  "<<wc<<endl;
	cout<<"Number of  words with ted is "<<tc<<endl;
	
	cout<<"frequency of words with ted is %"<<tedtotal<<endl;



	system("pause");
	return 0;
}

The word and ted count works. but the character counter breaks whenever I use upper-case,numbers,or other characters like ! or % because it doesn't count them for some reason. It's killing me because I know i'm missing something simple. Any hints would be greatly appreciated

[JockX]

You can't use the same counter i for two arrays lcount and carray, as the two have different sizes. For short inputs you get incorrect letter count, but for inputs over 91 characters your program is likely to crash.

for (int i = 0; i<size; i++)
{
   lcount[i] = charcount(t, carray[i], size);
}

[drmaniac]

I think I get what you're saying. Because I'm comparing the array to a key I made the for loop should also be set to the same size. Because the size wasn't the same it made it so my short test sentences didn't get far enough in the array to actually see the uppercase letters/numbers.