Help with do while loops

[Dreilly91]

For some reason this loop is repeating no matter what the user inputs, also the while loop runs every time. I know the while loop isn't needed and their are easier ways to do it but i'm just learning and practicing some of the thing i'm learning

        do{
            cout << "\n[Y]es | [N]o\n";
            cin >> done;

            while((done!='Y') || (done!='N') || (done!='n') || (done!='y'))
            {
                error();
                break;
            }

        }while((done!='Y') || (done!='N') || (done!='n') || (done!='y'));

[Zaki Al Qudah]

you could use an if statement instead of the inner while loop; i.e

if while((done!='Y') || (done!='N') || (done!='n') || (done!='y'))
{
    error();
}

Good Luck, Zaki

[The illusionist mirage]

Dreilly wrote:

For some reason this loop is repeating no matter what the user inputs, also the while loop runs every time

The reason is this:

while((done!='Y') || (done!='N') || (done!='n') || (done!='y'))

This part must be:

while(done != 'Y' && done != 'N' && done != 'y' && done != 'n')